[PATCH] contrib/completion: suppress stderror in bash completion of git remotes
- From
Matt Korostoff <mkorostoff@gmail.com>
- Date
- Feb 9, 2015, 20:58 UTC
- Message-ID
- <1423515508-40109-1-git-send-email-MKorostoff@gmail.com>
In some system configurations there is a bug with the __git_remotes function. Specifically, there is a problem with line 415, `test -d "$d/remotes" && ls -1 "$d/remotes"`. While `test -d` is meant to prevent listing the remotes directory if it does not exist, in some system, `ls` will run regardless.
This results in an error in which typing `git push or` + `tab` prints out `ls: .git/remotes: No such file or directory`. This can be fixed by simply directing stderror of this line to /dev/null. --- contrib/completion/git-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 2fece98..72251cc 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -412,7 +412,7 @@ __git_refs_remotes () __git_remotes () { local i IFS=$'\n' d="$(__gitdir)" - test -d "$d/remotes" && ls -1 "$d/remotes" + test -d "$d/remotes" && ls -1 "$d/remotes" 2>/dev/null for i in $(git --git-dir="$d" config --get-regexp 'remote\..*\.url' 2>/dev/null); do i="${i#remote.}" echo "${i/.url*/}"
-- 1.7.10.2 (Apple Git-33)