git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 10/10] commit: show "Author:" hint when the ident is not given explicitly

From
Jeff King <peff@peff.net>
Date
Jan 15, 2015, 07:17 UTC
Message-ID
<20150115071743.GF11028@peff.net>
In-Reply-To
<1421278855-8126-11-git-send-email-gitster@pobox.com>
On Wed, Jan 14, 2015 at 03:40:55PM -0800, Junio C Hamano wrote:
Show 16 quoted lines
> This is a knee-jerk response to two facts:
> 
>  - the author_ident_sufficiently_given() function is public but
>    nobody uses it;
> 
>  - a corresponding function committer_ident_sufficiently_given() is
>    used to determine when to add "Committer: " reminder in the log
>    message editor.
> 
> The existing logic decides to show "Author:" reminder when the
> author is different from the committer, so there won't be practical
> difference other than we would end up showing both reminders when a
> committer with iffy name derived from the heuristic is committing
> her own patch.
> 
> Which means this patch probably should be dropped.

Yeah, I seem to recall going through this logic myself recently and coming to the same conclusion (probably while working on fac9083). I don't think it is really adding anything to the one case where it triggers (and in fact looks a bit worse, as the author information is redundant).

-Peff
Previous: Junio C HamanoNext: Stefan Beller
Message 16 of 19 in “mark private symbols static”
  1. 00/10 mark private symbols staticJunio C Hamano, Jan 14, 2015
  2. 01/10 http.c: make finish_active_slot() and handle_curl_result() staticJunio C Hamano, Jan 14, 2015
  3. Jeff KingJan 15, 2015
  4. 02/10 line-log.c: make line_log_data_init() staticJunio C Hamano, Jan 14, 2015
  5. 03/10 prompt.c: remove git_getpass() nobody usesJunio C Hamano, Jan 14, 2015
  6. Jeff KingJan 15, 2015
  7. 04/10 revision.c: make save_parents() and free_saved_parents() staticJunio C Hamano, Jan 14, 2015
  8. 05/10 urlmatch.c: make match_urls() staticJunio C Hamano, Jan 14, 2015
  9. Jeff KingJan 15, 2015
  10. 06/10 remote.c: make clear_cas_option() staticJunio C Hamano, Jan 14, 2015
  11. 07/10 shallow.c: make check_shallow_file_for_update() staticJunio C Hamano, Jan 14, 2015
  12. 08/10 pack-bitmap.c: make pack_bitmap_filename() staticJunio C Hamano, Jan 14, 2015
  13. Jeff KingJan 15, 2015
  14. 09/10 read-cache.c: make fill/match_stat_data() staticJunio C Hamano, Jan 14, 2015
  15. 10/10 commit: show "Author:" hint when the ident is not given explicitlyJunio C Hamano, Jan 14, 2015
  16. Jeff KingJan 15, 2015
  17. Stefan BellerJan 15, 2015
  18. Jeff KingJan 15, 2015
  19. Junio C HamanoJan 15, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.