git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 08/10] pack-bitmap.c: make pack_bitmap_filename() static

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 14, 2015, 23:40 UTC
Message-ID
<1421278855-8126-9-git-send-email-gitster@pobox.com>
In-Reply-To
<1421278855-8126-1-git-send-email-gitster@pobox.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 pack-bitmap.c | 28 ++++++++++++++--------------
 pack-bitmap.h |  1 -
 2 files changed, 14 insertions(+), 15 deletions(-)
diff --git a/pack-bitmap.c b/pack-bitmap.c
index 6a81841..0cd85f6 100644
--- a/pack-bitmap.c
+++ b/pack-bitmap.c
@@ -252,6 +252,20 @@ static int load_bitmap_entries_v1(struct bitmap_index *index)
 	return 0;
 }
 
+static char *pack_bitmap_filename(struct packed_git *p)
+{
+	char *idx_name;
+	int len;
+
+	len = strlen(p->pack_name) - strlen(".pack");
+	idx_name = xmalloc(len + strlen(".bitmap") + 1);
+
+	memcpy(idx_name, p->pack_name, len);
+	memcpy(idx_name + len, ".bitmap", strlen(".bitmap") + 1);
+
+	return idx_name;
+}
+
 static int open_pack_bitmap_1(struct packed_git *packfile)
 {
 	int fd;
@@ -322,20 +336,6 @@ failed:
 	return -1;
 }
 
-char *pack_bitmap_filename(struct packed_git *p)
-{
-	char *idx_name;
-	int len;
-
-	len = strlen(p->pack_name) - strlen(".pack");
-	idx_name = xmalloc(len + strlen(".bitmap") + 1);
-
-	memcpy(idx_name, p->pack_name, len);
-	memcpy(idx_name + len, ".bitmap", strlen(".bitmap") + 1);
-
-	return idx_name;
-}
-
 static int open_pack_bitmap(void)
 {
 	struct packed_git *p;
diff --git a/pack-bitmap.h b/pack-bitmap.h
index 487600b..0adcef7 100644
--- a/pack-bitmap.h
+++ b/pack-bitmap.h
@@ -38,7 +38,6 @@ int prepare_bitmap_git(void);
 void count_bitmap_commit_list(uint32_t *commits, uint32_t *trees, uint32_t *blobs, uint32_t *tags);
 void traverse_bitmap_commit_list(show_reachable_fn show_reachable);
 void test_bitmap_walk(struct rev_info *revs);
-char *pack_bitmap_filename(struct packed_git *p);
 int prepare_bitmap_walk(struct rev_info *revs);
 int reuse_partial_packfile_from_bitmap(struct packed_git **packfile, uint32_t *entries, off_t *up_to);
 int rebuild_existing_bitmaps(struct packing_data *mapping, khash_sha1 *reused_bitmaps, int show_progress);
-- 
2.3.0-rc0-134-g109a908
Previous: Junio C HamanoNext: Jeff King
Message 12 of 19 in “mark private symbols static”
  1. 00/10 mark private symbols staticJunio C Hamano, Jan 14, 2015
  2. 01/10 http.c: make finish_active_slot() and handle_curl_result() staticJunio C Hamano, Jan 14, 2015
  3. Jeff KingJan 15, 2015
  4. 02/10 line-log.c: make line_log_data_init() staticJunio C Hamano, Jan 14, 2015
  5. 03/10 prompt.c: remove git_getpass() nobody usesJunio C Hamano, Jan 14, 2015
  6. Jeff KingJan 15, 2015
  7. 04/10 revision.c: make save_parents() and free_saved_parents() staticJunio C Hamano, Jan 14, 2015
  8. 05/10 urlmatch.c: make match_urls() staticJunio C Hamano, Jan 14, 2015
  9. Jeff KingJan 15, 2015
  10. 06/10 remote.c: make clear_cas_option() staticJunio C Hamano, Jan 14, 2015
  11. 07/10 shallow.c: make check_shallow_file_for_update() staticJunio C Hamano, Jan 14, 2015
  12. 08/10 pack-bitmap.c: make pack_bitmap_filename() staticJunio C Hamano, Jan 14, 2015
  13. Jeff KingJan 15, 2015
  14. 09/10 read-cache.c: make fill/match_stat_data() staticJunio C Hamano, Jan 14, 2015
  15. 10/10 commit: show "Author:" hint when the ident is not given explicitlyJunio C Hamano, Jan 14, 2015
  16. Jeff KingJan 15, 2015
  17. Stefan BellerJan 15, 2015
  18. Jeff KingJan 15, 2015
  19. Junio C HamanoJan 15, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.