Re: [PATCH] is_hfs_dotgit: loosen over-eager match of \u{..47}
On Tue, Dec 23, 2014 at 01:02:23PM -0800, Junio C Hamano wrote:
Show 19 quoted lines
> Jonathan Nieder <jrnieder@gmail.com> writes:
>
> >> +++ b/t/t1450-fsck.sh
> > [...]
> >> + git fsck 2>err &&
> >> + cat err &&
> >> + ! test -s err
> >
> > Nit: if this said
> >
> > test_line_count = 0 err
> >
> > then the error message would be more obvious when it fails with
> > --verbose.
>
> That's a good suggestion, I think. This is meant to apply on top of
> d08c13b, and we already had test_line_count back then.
>
> So far I collected these follow-ups to squash into Peff's patch.
They all look good to me. Thanks.
-Peff
Jeff King <peff@peff.net>