Re: [PATCH] is_hfs_dotgit: loosen over-eager match of \u{..47}

From: Jeff King <peff@peff.net>
Date: Dec 23, 2014, 21:09 UTC
Message-ID: <20141223210928.GA13304@peff.net>
In-Reply-To: <20141223201416.GA29365@google.com>

On Tue, Dec 23, 2014 at 12:14:16PM -0800, Jonathan Nieder wrote:

Show 12 quoted lines

> > +++ b/t/t1450-fsck.sh
> [...]
> > +		git fsck 2>err &&
> > +		cat err &&
> > +		! test -s err
> 
> Nit: if this said
> 
> 		test_line_count = 0 err
> 
> then the error message would be more obvious when it fails with
> --verbose.

Thanks, I actually considered adding a "test_file_is_empty" for that reason, but empty line-count does the same thing.

-Peff