git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: no-xmailer tests fail under Mac OS

From
Jeff King <peff@peff.net>
Date
Dec 11, 2014, 22:13 UTC
Message-ID
<20141211221339.GA9478@peff.net>
In-Reply-To
<xmqq1to5et1j.fsf@gitster.dls.corp.google.com>
On Thu, Dec 11, 2014 at 02:11:04PM -0800, Junio C Hamano wrote:
Show 22 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > On Fri, Dec 05, 2014 at 11:07:37PM -0800, Michael Blume wrote:
> >
> >> > Ah, right, we might be looking for 0 sometimes. The right way to do it
> >> > without destroying the &&-chaining is:
> >> >
> >> >   { grep ^X-Mailer: out || true } &&
> >> >   test_line_count = $expected mailer
> >> 
> >> Hmm, it doesn't look like that helper is &&-chained though? So it
> >> seems like we could just do without the &&
> >
> > You're right, but that is IMHO a bug. We would not notice if send-email
> > or format-patch barfed, and we are expecting to find no X-Mailer (we
> > wouldn't, but for the wrong reason).
> 
> Let me patch this up further by amending the SQUASH??? at the tip.
> 
>  t/t9001-send-email.sh | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> [...]
Yeah, looks good to me.
-Peff
Previous: Junio C HamanoNext: Luis Henriques
Message 8 of 9 in “no-xmailer tests fail under Mac OS”
  1. Michael BlumeDec 6, 2014
  2. Jeff KingDec 6, 2014
  3. Michael BlumeDec 6, 2014
  4. Jeff KingDec 6, 2014
  5. Junio C HamanoDec 9, 2014
  6. Jeff KingDec 6, 2014
  7. Junio C HamanoDec 11, 2014
  8. Jeff KingDec 11, 2014
  9. Luis HenriquesDec 11, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.