Re: no-xmailer tests fail under Mac OS
- From
Jeff King <peff@peff.net>
- Date
- Dec 6, 2014, 07:12 UTC
- Message-ID
- <20141206071234.GA6850@peff.net>
- In-Reply-To
- <CAO2U3QgDMpKwqsjzPNECpJw4z+WbboX5ug7Shu5v5ZCuPsKuGQ@mail.gmail.com>
On Fri, Dec 05, 2014 at 11:07:37PM -0800, Michael Blume wrote:
Show 8 quoted lines
> > Ah, right, we might be looking for 0 sometimes. The right way to do it
> > without destroying the &&-chaining is:
> >
> > { grep ^X-Mailer: out || true } &&
> > test_line_count = $expected mailer
>
> Hmm, it doesn't look like that helper is &&-chained though? So it
> seems like we could just do without the &&You're right, but that is IMHO a bug. We would not notice if send-email or format-patch barfed, and we are expecting to find no X-Mailer (we wouldn't, but for the wrong reason).
It should also be using test_config in the last two tests.
-Peff