Re: [PATCH] t0090: mark add-interactive test with PERL prerequisite

From: Jeff King <peff@peff.net>
Date: Nov 18, 2014, 18:49 UTC
Message-ID: <20141118184924.GB13479@peff.net>
In-Reply-To: <20141118184347.GE6527@google.com>

On Tue, Nov 18, 2014 at 10:43:47AM -0800, Jonathan Nieder wrote:

Show 8 quoted lines

> ... and here's a patch on top to give git-p4 the same treatment.
> 
> -- >8 --
> Subject: Makefile: have python scripts depend on NO_PYTHON setting
> 
> Like the perl scripts, python scripts need a dependency to ensure they
> are rebuilt when switching between the "dummy" versions that run
> without Python and the real thing.

Thanks, I didn't think to look for similar cases. It seems python is the only other thing that gets the "unimplemented" treatment. If you do:

  make
  make NO_TCLTK=Yes

I think you'll still end up with a crufty gitk build, but the fix there is much more involved (it would have to create a "Sorry, gitk wasn't built" script). I don't think it's worth the effort.

-Peff