git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t0090: mark add-interactive test with PERL prerequisite

From
Jeff King <peff@peff.net>
Date
Nov 18, 2014, 17:22 UTC
Message-ID
<20141118172231.GA16387@peff.net>

The add-interactive system is built in perl. If you build with NO_PERL, running "git commit --interactive" will exit with an error and the test will fail.

Signed-off-by: Jeff King <peff@peff.net>
---
Noticed by Michael while working around gitweb failures by setting
NO_PERL. :)

It didn't reproduce for me in my existing build directory, presumably because I had an old git-add--interactive build product lying around. But running the tests in a clean clone with NO_PERL set reproduces easily.

 t/t0090-cache-tree.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0090-cache-tree.sh b/t/t0090-cache-tree.sh
index 158cf4f..067f4c6 100755
--- a/t/t0090-cache-tree.sh
+++ b/t/t0090-cache-tree.sh
@@ -131,7 +131,7 @@ test_expect_success 'second commit has cache-tree' '
 	test_cache_tree
 '
 
-test_expect_success 'commit --interactive gives cache-tree on partial commit' '
+test_expect_success PERL 'commit --interactive gives cache-tree on partial commit' '
 	cat <<-\EOT >foo.c &&
 	int foo()
 	{
-- 
2.1.2.596.g7379948
Next: Jeff King
Message 1 of 11 in “t0090: mark add-interactive test with PERL prerequisite”
  1. t0090: mark add-interactive test with PERL prerequisiteJeff King, Nov 18, 2014
  2. t960[34]: mark cvsimport tests as requiring perlJeff King, Nov 18, 2014
  3. Jonathan NiederNov 18, 2014
  4. Jeff KingNov 18, 2014
  5. Jeff KingNov 18, 2014
  6. Jonathan NiederNov 18, 2014
  7. Jonathan NiederNov 18, 2014
  8. Jeff KingNov 18, 2014
  9. Pete WyckoffNov 18, 2014
  10. Jeff KingNov 18, 2014
  11. Jonathan NiederNov 18, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.