Re: [PATCH 2/2] use env_array member of struct child_process
- From
Jeff King <peff@peff.net>
- Date
- Oct 20, 2014, 09:19 UTC
- Message-ID
- <20141020091949.GB12913@peff.net>
- In-Reply-To
- <54439D0C.1070308@web.de>
On Sun, Oct 19, 2014 at 01:14:20PM +0200, René Scharfe wrote:
Show 8 quoted lines
> --- a/wt-status.c
> +++ b/wt-status.c
> @@ -726,14 +726,14 @@ static void wt_status_print_changed(struct wt_status *s)
> static void wt_status_print_submodule_summary(struct wt_status *s, int uncommitted)
> {
> struct child_process sm_summary = CHILD_PROCESS_INIT;
> - struct argv_array env = ARGV_ARRAY_INIT;
> struct argv_array argv = ARGV_ARRAY_INIT;I don't think it belongs in this patch, but a follow-on 3/2 might be to give argv the same treatment.
-Peff