Re: [PATCH RFC] git-am: support any number of signatures

From: Michael S. Tsirkin <mst@redhat.com>
Date: Sep 22, 2014, 14:01 UTC
Message-ID: <20140922140144.GA9769@redhat.com>
In-Reply-To: <xmqq38f2jed3.fsf@gitster.dls.corp.google.com>

On Wed, Jun 18, 2014 at 10:51:04AM -0700, Junio C Hamano wrote:

Show 32 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
> > On Tue, Jun 17, 2014 at 8:09 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> >>
> >> OK, after looking into this for a while, I realize
> >> this is a special property of the Signed-off-by footer.
> >> For now I think it's reasonable to just avoid de-duplicating
> >> other footers if any. Agree?
> >
> > Not really. I'd rather see "git am" hardcode as little such policy as possible.
> > We do need to support S-o-b footer and the policy we defined for it long time
> > ago, if only for backward compatiblity, but for any other footers,
> > policy decision
> > such as "dedup by default" isn't something "am" should know about.
> 
> By the way, "append without looking for dups" is a policy decision
> that is as bad to have as "append with dedup".
> 
> I'd rather not to see "am.signoff", or any name that implies what
> the "-s" option to the command is about for that matter, to be used
> in futzing with the trailers other than S-o-b in any way.  As I
> understand it, our longer term goal is to defer that task, including
> the user-programmable policy decisions, to something like the
> 'trailer' Christian started.
> 
> I suspect that it may add unnecessary work later if we overloaded
> "signoff" with a similar feature with the change under discussion.
> I would feel safer to see it outlined how we envision to transition
> to a more generic 'trailer' solution later if we were to enhance
> "am" with "am.signoff" now.
> 
> Thanks.

Hi Junio, Christian, it's been a while. I see that the work on trailers is going on. I tried going over the documentation but I could not figure out how would one implement multiple signatures using the trailers mechanism.

As a reminder, this old patchset (that I replied to) enhanced git am -s
with an option to add different signatures depending on
the option passed to the -s flag.
E.g. I have
[am "a"]
        signoff = "Acked-by: Michael S. Tsirkin <mst@redhat.com>"

[am "r"]
        signoff = "Reviewed-by: Michael S. Tsirkin <mst@redhat.com>"

[am "t"]
        signoff = "Tested-by: Michael S. Tsirkin <mst@redhat.com>"

and now:
	git am -s art
adds all 3 signatures when applying the patch.

Any help will be appreciated.

-- 
MST