Re: [PATCH RFC] git-am: support any number of signatures

From: Michael S. Tsirkin <mst@redhat.com>
Date: Jun 18, 2014, 03:09 UTC
Message-ID: <20140618030903.GA19593@redhat.com>
In-Reply-To: <xmqqy4wwraoz.fsf@gitster.dls.corp.google.com>

On Mon, Jun 16, 2014 at 11:06:20AM -0700, Junio C Hamano wrote:

Show 11 quoted lines

> "Michael S. Tsirkin" <mst@redhat.com> writes:
> 
> > Now A wants to sign this patch.
> >
> > I think there are two reasonable ways to behave:
> > 1. What you describe above:
> > A
> > B
> > A
> 
> That is the only sensible thing to do for Signed-off-by footers.

OK, after looking into this for a while, I realize this is a special property of the Signed-off-by footer. For now I think it's reasonable to just avoid de-duplicating other footers if any. Agree?

To have it apply to other footers, will have to implement ^[A-Z]*-by: logic that I have implemented for sendemail, in am as well. I'll get back to that, but I think it's separate from this feature.

-- 
MST