git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] tag: support configuring --sort via .gitconfig

From
Jeff King <peff@peff.net>
Date
Jul 10, 2014, 19:34 UTC
Message-ID
<20140710193404.GA15615@sigill.intra.peff.net>
In-Reply-To
<xmqqa98h8587.fsf@gitster.dls.corp.google.com>
On Thu, Jul 10, 2014 at 10:59:36AM -0700, Junio C Hamano wrote:
Show 13 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > I know this is existing code you are moving, but I noticed it looks ripe
> > for using skip_prefix. Perhaps while we are in the area we should do the
> > following on top of your patch (I'd also be happy for it be squashed
> > in, but that may be too much in one patch).
> 
> I am tempted to suggest going the other way around, i.e. queue (an
> equivalent of) this on jk/skip-prefix and merge it to 'next' and
> then 'master' quickly.
> 
> I can go either way, but I tend to prefer building new things on top
> of obviously correct clean-up, not the other way around.

Me too. I just didn't want to make more work for Jacob (in having to rebase on top of mine) or for you (in having to do a non-obvious merge a few days from now).

-Peff
Previous: Junio C HamanoNext: Keller, Jacob E
Message 5 of 8 in “tag: support configuring --sort via .gitconfig”
  1. tag: support configuring --sort via .gitconfigJacob Keller, Jul 9, 2014
  2. Jeff KingJul 10, 2014
  3. Jeff KingJul 10, 2014
  4. Junio C HamanoJul 10, 2014
  5. Jeff KingJul 10, 2014
  6. Keller, Jacob EJul 10, 2014
  7. Junio C HamanoJul 10, 2014
  8. Keller, Jacob EJul 10, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.