Re: [PATCH v2] tag: support configuring --sort via .gitconfig

From: Keller, Jacob E <jacob.e.keller@intel.com>
Date: Jul 10, 2014, 21:50 UTC
Message-ID: <1405029028.4925.32.camel@jekeller-desk1.amr.corp.intel.com>
In-Reply-To: <20140710193404.GA15615@sigill.intra.peff.net>

On Thu, 2014-07-10 at 15:34 -0400, Jeff King wrote:

Show 21 quoted lines

> On Thu, Jul 10, 2014 at 10:59:36AM -0700, Junio C Hamano wrote:
> 
> > Jeff King <peff@peff.net> writes:
> > 
> > > I know this is existing code you are moving, but I noticed it looks ripe
> > > for using skip_prefix. Perhaps while we are in the area we should do the
> > > following on top of your patch (I'd also be happy for it be squashed
> > > in, but that may be too much in one patch).
> > 
> > I am tempted to suggest going the other way around, i.e. queue (an
> > equivalent of) this on jk/skip-prefix and merge it to 'next' and
> > then 'master' quickly.
> > 
> > I can go either way, but I tend to prefer building new things on top
> > of obviously correct clean-up, not the other way around.
> 
> Me too. I just didn't want to make more work for Jacob (in having to
> rebase on top of mine) or for you (in having to do a non-obvious merge a
> few days from now).
> 
> -Peff

I'm perfectly fine rebasing. :)

Thanks, Jake