Re: [PATCH] gitk: catch mkdtemp errors

From: Paul Mackerras <paulus@samba.org>
Date: Jun 27, 2014, 06:59 UTC
Message-ID: <20140627065924.GB21103@iris.ozlabs.ibm.com>
In-Reply-To: <xmqq4mz74cuv.fsf@gitster.dls.corp.google.com>

On Thu, Jun 26, 2014 at 01:47:36PM -0700, Junio C Hamano wrote:

Show 17 quoted lines

> David Aguilar <davvid@gmail.com> writes:
> 
> > 105b5d3fbb1c00bb0aeaf9d3e0fbe26a7b1993fc introduced a dependency
> > on mkdtemp, which is not available on Windows.
> >
> > Use the original temporary directory behavior when mkdtemp fails.
> > This makes the code use mkdtemp when available and gracefully
> > fallback to the existing behavior when it is not available.
> >
> > Helped-by: Junio C Hamano <gitster@pobox.com>
> > Helped-by: brian m. carlson <sandals@crustytoothpaste.net>
> > Signed-off-by: David Aguilar <davvid@gmail.com>
> > ---
> 
> In the meantime, I've fetched from you and merged up to your
> master~2 aka 17f9836c (gitk: Show staged submodules regardless of
> ignore config, 2014-04-08).

I have applied and pushed out this patch, along with one from Max Kirillov, so please do another fetch.

Thanks, Paul.