Re: [PATCH] gitk: catch mkdtemp errors

From: David Aguilar <davvid@gmail.com>
Date: Jun 27, 2014, 03:05 UTC
Message-ID: <20140627030540.GB50083@gmail.com>
In-Reply-To: <xmqq8uoj4d43.fsf@gitster.dls.corp.google.com>

On Thu, Jun 26, 2014 at 01:42:04PM -0700, Junio C Hamano wrote:

Show 15 quoted lines

> David Aguilar <davvid@gmail.com> writes:
> 
> > 105b5d3fbb1c00bb0aeaf9d3e0fbe26a7b1993fc introduced a dependency
> > on mkdtemp, which is not available on Windows.
> >
> > Use the original temporary directory behavior when mkdtemp fails.
> > This makes the code use mkdtemp when available and gracefully
> > fallback to the existing behavior when it is not available.
> >
> > Helped-by: Junio C Hamano <gitster@pobox.com>
> > Helped-by: brian m. carlson <sandals@crustytoothpaste.net>
> > Signed-off-by: David Aguilar <davvid@gmail.com>
> > ---
> 
> Does this still need to be applied before I can pull from Paulus?

Yes, it would be nice to have this, especially for Windows users.

-- 
David