git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/5] t7510: check %G* pretty-format output

From
Jeff King <peff@peff.net>
Date
Jun 17, 2014, 00:06 UTC
Message-ID
<20140617000623.GD17110@sigill.intra.peff.net>
In-Reply-To
<20140616235917.GA19499@sigill.intra.peff.net>

We do not check these along with the other pretty-format placeholders in t6006, because we need signed commits to make them interesting. t7510 has such commits, and can easily exercise them in addition to the regular --show-signature code path.

Signed-off-by: Jeff King <peff@peff.net>
---
Similar to before, but with the 'U' test added in.
 t/t7510-signed-commit.sh | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)
diff --git a/t/t7510-signed-commit.sh b/t/t7510-signed-commit.sh
index 04fc2c5..e97477a 100755
--- a/t/t7510-signed-commit.sh
+++ b/t/t7510-signed-commit.sh
@@ -107,4 +107,44 @@ test_expect_success GPG 'amending already signed commit' '
 	! grep "BAD signature from" actual
 '
 
+test_expect_success GPG 'show good signature with custom format' '
+	cat >expect <<-\EOF &&
+	G
+	13B6F51ECDDE430D
+	C O Mitter <committer@example.com>
+	EOF
+	git log -1 --format="%G?%n%GK%n%GS" sixth-signed >actual &&
+	test_cmp expect actual
+'
+
+test_expect_success GPG 'show bad signature with custom format' '
+	cat >expect <<-\EOF &&
+	B
+	13B6F51ECDDE430D
+	C O Mitter <committer@example.com>
+	EOF
+	git log -1 --format="%G?%n%GK%n%GS" $(cat forged1.commit) >actual &&
+	test_cmp expect actual
+'
+
+test_expect_success GPG 'show unknown signature with custom format' '
+	cat >expect <<-\EOF &&
+	U
+	61092E85B7227189
+	Eris Discordia <discord@example.net>
+	EOF
+	git log -1 --format="%G?%n%GK%n%GS" eighth-signed-alt >actual &&
+	test_cmp expect actual
+'
+
+test_expect_success GPG 'show lack of signature with custom format' '
+	cat >expect <<-\EOF &&
+	N
+
+
+	EOF
+	git log -1 --format="%G?%n%GK%n%GS" seventh-unsigned >actual &&
+	test_cmp expect actual
+'
+
 test_done
-- 
2.0.0.566.gfe3e6b2
Previous: Jeff KingNext: Jeff King
Message 9 of 10 in “pretty: avoid reading past end-of-string with "%G"”
  1. pretty: avoid reading past end-of-string with "%G"Jeff King, Jun 16, 2014
  2. t7510: check %G* pretty-format outputJeff King, Jun 16, 2014
  3. Eric SunshineJun 16, 2014
  4. Jeff KingJun 16, 2014
  5. 0/5 --format=%G tests and fixesJeff King, Jun 16, 2014
  6. 1/5 t7510: stop referring to master in later testsJeff King, Jun 16, 2014
  7. 2/5 t7510: use consistent &&-chains in loopJeff King, Jun 17, 2014
  8. 3/5 t7510: test a commit signed by an unknown keyJeff King, Jun 17, 2014
  9. 4/5 t7510: check %G* pretty-format outputJeff King, Jun 17, 2014
  10. 5/5 pretty: avoid reading past end-of-string with "%G"Jeff King, Jun 17, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.