git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/5] t7510: stop referring to master in later tests

From
Jeff King <peff@peff.net>
Date
Jun 16, 2014, 23:59 UTC
Message-ID
<20140616235958.GA17110@sigill.intra.peff.net>
In-Reply-To
<20140616235917.GA19499@sigill.intra.peff.net>

Our setup creates a sequence of commits, each with its own tag. However, we sometimes refer to "seventh-signed" as "master". This works, since it is at the tip of the created branch, but is brittle if new tests need to add more commits. Let's use its tag name to be unambiguous.

Signed-off-by: Jeff King <peff@peff.net>
---
 t/t7510-signed-commit.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/t7510-signed-commit.sh b/t/t7510-signed-commit.sh
index 5ddac1a..37c3778 100755
--- a/t/t7510-signed-commit.sh
+++ b/t/t7510-signed-commit.sh
@@ -47,7 +47,7 @@ test_expect_success GPG 'create signed commits' '
 
 test_expect_success GPG 'show signatures' '
 	(
-		for commit in initial second merge fourth-signed fifth-signed sixth-signed master
+		for commit in initial second merge fourth-signed fifth-signed sixth-signed seventh-signed
 		do
 			git show --pretty=short --show-signature $commit >actual &&
 			grep "Good signature from" actual || exit 1
@@ -67,7 +67,7 @@ test_expect_success GPG 'show signatures' '
 '
 
 test_expect_success GPG 'detect fudged signature' '
-	git cat-file commit master >raw &&
+	git cat-file commit seventh-signed >raw &&
 
 	sed -e "s/seventh/7th forged/" raw >forged1 &&
 	git hash-object -w -t commit forged1 >forged1.commit &&
@@ -77,7 +77,7 @@ test_expect_success GPG 'detect fudged signature' '
 '
 
 test_expect_success GPG 'detect fudged signature with NUL' '
-	git cat-file commit master >raw &&
+	git cat-file commit seventh-signed >raw &&
 	cat raw >forged2 &&
 	echo Qwik | tr "Q" "\000" >>forged2 &&
 	git hash-object -w -t commit forged2 >forged2.commit &&
-- 
2.0.0.566.gfe3e6b2
Previous: Jeff KingNext: Jeff King
Message 6 of 10 in “pretty: avoid reading past end-of-string with "%G"”
  1. pretty: avoid reading past end-of-string with "%G"Jeff King, Jun 16, 2014
  2. t7510: check %G* pretty-format outputJeff King, Jun 16, 2014
  3. Eric SunshineJun 16, 2014
  4. Jeff KingJun 16, 2014
  5. 0/5 --format=%G tests and fixesJeff King, Jun 16, 2014
  6. 1/5 t7510: stop referring to master in later testsJeff King, Jun 16, 2014
  7. 2/5 t7510: use consistent &&-chains in loopJeff King, Jun 17, 2014
  8. 3/5 t7510: test a commit signed by an unknown keyJeff King, Jun 17, 2014
  9. 4/5 t7510: check %G* pretty-format outputJeff King, Jun 17, 2014
  10. 5/5 pretty: avoid reading past end-of-string with "%G"Jeff King, Jun 17, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.