Re: [PATCH v5 0/4] commit: Add commit.verbose configuration
- From
Caleb Thompson <caleb@calebthompson.io>
- Date
- Jun 13, 2014, 16:49 UTC
- Message-ID
- <20140613164910.GA87252@sirius.local>
- In-Reply-To
- <20140612203010.GA17761@hudson.localdomain>
On Thu, Jun 12, 2014 at 01:30:10PM -0700, Jeremiah Mahler wrote:
Show 44 quoted lines
> On Thu, Jun 12, 2014 at 02:38:58PM -0500, Caleb Thompson wrote:
> > This patch allows people to set commit.verbose to implicitly send
> > --verbose to git-commit.
> >
> > This version incorporates changes suggested by Eric Sunshine, Duy
> > Nguyen, and Jeremiah Mahler.
> >
> > It introduces several cleanup patches to t/t7505-commit-verbose.sh to
> > bring it closer to the current state of the tests as Eric has explained
> > them to me, then adds the verbose config and --no-verbose flag.
> >
> > Since the last version of this patch
> > (http://marc.info/?l=git&m=140251155830422&w=2), I've made the following
> > changes:
> >
> > * Revert change to flags, as --no-verbose already existed and worked as
> > expected with the commit.verbose configuration. Thanks to René Scharfe.
> > * Fix <<-'EOS' style for check-for-no-diff script. Thanks to Mike Burns.
> >
> > Additionally, this set of patches was generated by format-patch, so it
> > should work correctly with git-am.
> >
> > ------------------------------------------------------
> >
> > Caleb Thompson (4):
> > commit test: Use test_config instead of git-config
> > commit test: Use write_script
> > commit test: test_set_editor in each test
> > commit: add commit.verbose configuration
> >
> > Documentation/config.txt | 5 +++
> > Documentation/git-commit.txt | 8 ++++-
> > builtin/commit.c | 4 +++
> > contrib/completion/git-completion.bash | 1 +
> > t/t7507-commit-verbose.sh | 64 +++++++++++++++++++++++++---------
> > 5 files changed, 64 insertions(+), 18 deletions(-)
> >
> > --
> > 2.0.0
> >
>
> The patches look good, they apply clean ('git am'), and all tests pass.
>
> Reviewed-by: Jeremiah Mahler <jmmahler@gmail.com>So that I'm clear on the etiquitte, is it appropriate for me to add this Reviewed-by line to the commit messages at this point, provided that the patches don't change?
> -- > Jeremiah Mahler > jmmahler@gmail.com > http://github.com/jmahler