[PATCH v5 2/4] commit test: Use write_script
- From
Caleb Thompson <caleb@calebthompson.io>
- Date
- Jun 12, 2014, 19:39 UTC
- Message-ID
- <1402601942-45553-3-git-send-email-caleb@calebthompson.io>
- In-Reply-To
- <1402601942-45553-1-git-send-email-caleb@calebthompson.io>
Use write_script from t/test-lib-functions.sh instead of cat, shebang, and chmod. This protects us from potential shell meta-characters in the name of our trash directory, which would be interpreted if we set $EDITOR directly.
Signed-off-by: Caleb Thompson <caleb@calebthompson.io> --- t/t7507-commit-verbose.sh | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh index 6d778ed..db09107 100755 --- a/t/t7507-commit-verbose.sh +++ b/t/t7507-commit-verbose.sh @@ -3,11 +3,9 @@ test_description='verbose commit template' . ./test-lib.sh -cat >check-for-diff <<EOF -#!$SHELL_PATH -exec grep '^diff --git' "\$1" +write_script check-for-diff <<-'EOF' + exec grep '^diff --git' "$1" EOF -chmod +x check-for-diff test_set_editor "$PWD/check-for-diff" cat >message <<'EOF'
-- 2.0.0