git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/7] test: turn USR_BIN_TIME into a lazy prerequisite

From
Jeff King <peff@peff.net>
Date
Jun 13, 2014, 07:45 UTC
Message-ID
<20140613074512.GG7908@sigill.intra.peff.net>
In-Reply-To
<1402356175-7249-3-git-send-email-gitster@pobox.com>
On Mon, Jun 09, 2014 at 04:22:50PM -0700, Junio C Hamano wrote:
> Two test scripts (t3302 and t3419) had copy & paste code to set
> USR_BIN_TIME prerequisite.  Use the test_lazy_prereq helper to define
> them in the common t/test-lib.sh.
I have to wonder why we even have such a prereq in the first place.

Many tests which use EXPENSIVE are sensible; we used to do something bad with large values, we fixed it, and want to be able to test the correctness of the fix. The use in t0021 looks like that.

However, the tests in t3302 and t3419, which use both EXPENSIVE and USR_BIN_TIME, seem like they are really interested in performance testing. I think they probably should be in t/perf in the first place (the reason they are not is presumably because they predate it).

Other than that, your series looks fine.
-Peff
PS s/expesive/expensive/ in the commit message of 7/7
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 9 in “A few minor test-prereq updates”
  1. 0/7 A few minor test-prereq updatesJunio C Hamano, Jun 9, 2014
  2. 1/7 test: turn EXPENSIVE into a lazy prerequisiteJunio C Hamano, Jun 9, 2014
  3. 2/7 test: turn USR_BIN_TIME into a lazy prerequisiteJunio C Hamano, Jun 9, 2014
  4. Jeff KingJun 13, 2014
  5. 3/7 t3302: coding style updatesJunio C Hamano, Jun 9, 2014
  6. 4/7 t3302: do not chdir around in the primary test processJunio C Hamano, Jun 9, 2014
  7. 5/7 t3302: drop unnecessary NOT_EXPENSIVE pseudo-prerequisiteJunio C Hamano, Jun 9, 2014
  8. 6/7 t3419: drop unnecessary NOT_EXPENSIVE pseudo-prerequisiteJunio C Hamano, Jun 9, 2014
  9. 7/7 tests: drop GIT_*_TIMING_TESTS environment variable supportJunio C Hamano, Jun 9, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.