git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/7] test: turn EXPENSIVE into a lazy prerequisite

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 9, 2014, 23:22 UTC
Message-ID
<1402356175-7249-2-git-send-email-gitster@pobox.com>
In-Reply-To
<1402356175-7249-1-git-send-email-gitster@pobox.com>

Two test scripts (t0021 and t5551) had copy & paste code to set EXPENSIVE prerequisite. Use the test_lazy_prereq helper to define them in the common t/test-lib.sh.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t0021-conversion.sh | 2 --
 t/t5551-http-fetch.sh | 2 --
 t/test-lib.sh         | 4 ++++
 3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t0021-conversion.sh b/t/t0021-conversion.sh
index b92e6cb..f890c54 100755
--- a/t/t0021-conversion.sh
+++ b/t/t0021-conversion.sh
@@ -190,8 +190,6 @@ test_expect_success 'required filter clean failure' '
 	test_must_fail git add test.fc
 '
 
-test -n "$GIT_TEST_LONG" && test_set_prereq EXPENSIVE
-
 test_expect_success EXPENSIVE 'filter large file' '
 	git config filter.largefile.smudge cat &&
 	git config filter.largefile.clean cat &&
diff --git a/t/t5551-http-fetch.sh b/t/t5551-http-fetch.sh
index afb439e..d697393 100755
--- a/t/t5551-http-fetch.sh
+++ b/t/t5551-http-fetch.sh
@@ -214,8 +214,6 @@ test_expect_success 'cookies stored in http.cookiefile when http.savecookies set
 	test_cmp expect_cookies.txt cookies_tail.txt
 '
 
-test -n "$GIT_TEST_LONG" && test_set_prereq EXPENSIVE
-
 test_expect_success EXPENSIVE 'create 50,000 tags in the repo' '
 	(
 	cd "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" &&
diff --git a/t/test-lib.sh b/t/test-lib.sh
index b25249e..d70d05e 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -855,6 +855,10 @@ test_lazy_prereq AUTOIDENT '
 	git var GIT_AUTHOR_IDENT
 '
 
+test_lazy_prereq EXPENSIVE '
+	test -n "$GIT_TEST_LONG"
+'
+
 # When the tests are run as root, permission tests will report that
 # things are writable when they shouldn't be.
 test -w / || test_set_prereq SANITY
-- 
2.0.0-435-g307a092
Previous: Junio C HamanoNext: Junio C Hamano
Message 2 of 9 in “A few minor test-prereq updates”
  1. 0/7 A few minor test-prereq updatesJunio C Hamano, Jun 9, 2014
  2. 1/7 test: turn EXPENSIVE into a lazy prerequisiteJunio C Hamano, Jun 9, 2014
  3. 2/7 test: turn USR_BIN_TIME into a lazy prerequisiteJunio C Hamano, Jun 9, 2014
  4. Jeff KingJun 13, 2014
  5. 3/7 t3302: coding style updatesJunio C Hamano, Jun 9, 2014
  6. 4/7 t3302: do not chdir around in the primary test processJunio C Hamano, Jun 9, 2014
  7. 5/7 t3302: drop unnecessary NOT_EXPENSIVE pseudo-prerequisiteJunio C Hamano, Jun 9, 2014
  8. 6/7 t3419: drop unnecessary NOT_EXPENSIVE pseudo-prerequisiteJunio C Hamano, Jun 9, 2014
  9. 7/7 tests: drop GIT_*_TIMING_TESTS environment variable supportJunio C Hamano, Jun 9, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.