git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 1/4] commit test: Use test_config instead of git-config

From
Caleb Thompson <caleb@calebthompson.io>
Date
Jun 12, 2014, 19:23 UTC
Message-ID
<20140612192340.GA44281@sirius.local>
In-Reply-To
<20140612184637.GA16641@hudson.localdomain>
Jeremiah,

That looks great. Since I'm not seeing any more feedback on the code for this set of patches, I'll go ahead and send up another set.

Thank you for those pointers.
Caleb Thompson
On Thu, Jun 12, 2014 at 11:46:37AM -0700, Jeremiah Mahler wrote:
Show 58 quoted lines
> Caleb,
>
> On Thu, Jun 12, 2014 at 01:23:41PM -0500, Caleb Thompson wrote:
> > Jeremiah,
> >
> > On Thu, Jun 12, 2014 at 11:04:59AM -0700, Jeremiah Mahler wrote:
> > >
> ...
> > >
> > > How are you preparing your patches.  'git format-patch' with a 'git
> > > send-email'?
> >
> > I'm so glad you asked, because I've just been muddling through this.
> >
> > I've been generating the cover page variously with request-pull or diff
> > --stat, then running a command like this, with --cc arguments added from
> > a list I've been keeping of people who respond to the threads:
> >
> >     git send-email --compose --to=git@vger.kernel.org --thread \
> >         [--cc ...] --no-chain-reply origin/master...
> >
> > Then I manually edit the subjects to add the version to the [PATCH N/M]
> > portions. I haven't been using format-patch.
> >
> > It's interesting that only the first patch isn't applying. I'd love to
> > hear a better way.
> >
> > Caleb
>
> It sounds like you are doing too much work.
>
> After I make a series of commits I run format-patch.  This example has 2
> patches (-2).  I like --thread, although it seems to work fine without
> it.  And --reroll-count will automatically do your N/M numbering for
> you.  It also generates a cover letter which you can then edit by hand.
> All the patches will be named v3-* in this case.
>
>   git format-patch --reroll-count=3 --cover --thread -2
>
> Then I can send the whole patch series using send-email.
>
>   git send-email --to=caleb --cc=git --cc=junio v3-*
>
> Felipe Contreras has a good writeup [1] on how to setup aliases with Mutt so
> you don't have to type the full email every time.
>
> [1]: http://felipec.wordpress.com/2009/10/25/git-send-email-tricks/
>
> I recently setup Mutt with Offlineimap [2] and Msmtp.  This is an
> awesome setup too.  Not patch related, but it makes the email part
> easier.
>
> [2]: https://wiki.archlinux.org/index.php/OfflineIMAP
>
> --
> Jeremiah Mahler
> jmmahler@gmail.com
> http://github.com/jmahler
Previous: Jeremiah MahlerNext: caleb@calebthompson.io
Message 9 of 15 in “commit: support commit.verbose and --no-verbose”
  1. 0/4 commit: support commit.verbose and --no-verbosecaleb@calebthompson.io, Jun 11, 2014
  2. 1/4 commit test: Use test_config instead of git-configcaleb@calebthompson.io, Jun 11, 2014
  3. Jeremiah MahlerJun 12, 2014
  4. Caleb ThompsonJun 12, 2014
  5. Jeremiah MahlerJun 12, 2014
  6. Jeremiah MahlerJun 12, 2014
  7. Caleb ThompsonJun 12, 2014
  8. Jeremiah MahlerJun 12, 2014
  9. Caleb ThompsonJun 12, 2014
  10. 2/4 commit test: Use write_scriptcaleb@calebthompson.io, Jun 11, 2014
  11. 3/4 commit test: test_set_editor in each testcaleb@calebthompson.io, Jun 11, 2014
  12. 4/4 commit: support commit.verbose and --no-verbosecaleb@calebthompson.io, Jun 11, 2014
  13. René ScharfeJun 11, 2014
  14. Caleb ThompsonJun 11, 2014
  15. Caleb ThompsonJun 12, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.