git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 0/4] commit: support commit.verbose and --no-verbose

From
caleb@calebthompson.io <caleb@calebthompson.io>
Date
Jun 11, 2014, 18:24 UTC
Message-ID
<1402511079-17735-1-git-send-email-caleb@calebthompson.io>

This patch allows people to set commit.verbose to implicitly send --verbose to git-commit. It also introduces --no-verbose to override the configuration setting.

This version incorporates changes suggested by Eric Sunshine, Duy Nguyen, and Jeremiah Mahler.

It introduces several cleanup patches to t/t7505-commit-verbose.sh to bring it closer to the current state of the tests as Eric has explained them to me, then adds the verbose config and --no-verbose flag.

Since the last version of this patch (http://marc.info/?l=git&m=140113063517118&w=2), I've made the following changes:

* Remove the $PWD => $(pwd) change, as it was a misunderstanding of
  t/README (Thank you to Johannes and David for pointing that out and
  clarifying)
* Use consistent test naming (Thanks to Jeremiah)
* Switch from <<-EOF to <<-'EOF' without manual escaping in write_script
  calls for the test editors check-for-diff and check-for-no-diff. The
  proposed <<-\EOF syntax did not properly prevent the parameter
  substitution on my machine, as both Eric and the documentation
  suggested it should, but the quoted version seems to work fine.
  (Thanks to Eric)
* Fix extra test_set_editor invocations and broken %%-chains created as a result
  of the test_set_editor changes. (Thanks again to Eric)
------------------------------------------------------
Caleb Thompson (4):
      commit test: Use test_config instead of git-config
      commit test: Use write_script
      commit test: test_set_editor in each test
      commit: support commit.verbose and --no-verbose
 Documentation/config.txt               |  5 +++++
 Documentation/git-commit.txt           |  8 +++++++-
 builtin/commit.c                       |  6 +++++-
 contrib/completion/git-completion.bash |  1 +
 t/t7507-commit-verbose.sh              | 64 +++++++++++++++++++++++++++++++++++++++++++++++-----------------
 5 files changed, 65 insertions(+), 19 deletions(-)
Next: caleb@calebthompson.io
Message 1 of 15 in “commit: support commit.verbose and --no-verbose”
  1. 0/4 commit: support commit.verbose and --no-verbosecaleb@calebthompson.io, Jun 11, 2014
  2. 1/4 commit test: Use test_config instead of git-configcaleb@calebthompson.io, Jun 11, 2014
  3. Jeremiah MahlerJun 12, 2014
  4. Caleb ThompsonJun 12, 2014
  5. Jeremiah MahlerJun 12, 2014
  6. Jeremiah MahlerJun 12, 2014
  7. Caleb ThompsonJun 12, 2014
  8. Jeremiah MahlerJun 12, 2014
  9. Caleb ThompsonJun 12, 2014
  10. 2/4 commit test: Use write_scriptcaleb@calebthompson.io, Jun 11, 2014
  11. 3/4 commit test: test_set_editor in each testcaleb@calebthompson.io, Jun 11, 2014
  12. 4/4 commit: support commit.verbose and --no-verbosecaleb@calebthompson.io, Jun 11, 2014
  13. René ScharfeJun 11, 2014
  14. Caleb ThompsonJun 11, 2014
  15. Caleb ThompsonJun 12, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.