git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 6/8] strbuf: add strbuf_reencode helper

From
Jeff King <peff@peff.net>
Date
May 22, 2014, 09:30 UTC
Message-ID
<20140522093014.GF15032@sigill.intra.peff.net>
In-Reply-To
<20140522092824.GA14530@sigill.intra.peff.net>

This is a convenience wrapper around `reencode_string_len` and `strbuf_attach`.

Signed-off-by: Jeff King <peff@peff.net>
---
 Documentation/technical/api-strbuf.txt |  5 +++++
 strbuf.c                               | 17 +++++++++++++++++
 strbuf.h                               |  1 +
 3 files changed, 23 insertions(+)
diff --git a/Documentation/technical/api-strbuf.txt b/Documentation/technical/api-strbuf.txt
index 3350d97..9d28b03 100644
--- a/Documentation/technical/api-strbuf.txt
+++ b/Documentation/technical/api-strbuf.txt
@@ -125,6 +125,11 @@ Functions
 
 	Strip whitespace from the end of a string.
 
+`strbuf_reencode`::
+
+	Replace the contents of the strbuf with a reencoded form.  Returns -1
+	on error, 0 on success.
+
 `strbuf_cmp`::
 
 	Compare two buffers. Returns an integer less than, equal to, or greater
diff --git a/strbuf.c b/strbuf.c
index ee96dcf..fc7290f 100644
--- a/strbuf.c
+++ b/strbuf.c
@@ -1,5 +1,6 @@
 #include "cache.h"
 #include "refs.h"
+#include "utf8.h"
 
 int starts_with(const char *str, const char *prefix)
 {
@@ -106,6 +107,22 @@ void strbuf_ltrim(struct strbuf *sb)
 	sb->buf[sb->len] = '\0';
 }
 
+int strbuf_reencode(struct strbuf *sb, const char *from, const char *to)
+{
+	char *out;
+	int len;
+
+	if (same_encoding(from, to))
+		return 0;
+
+	out = reencode_string_len(sb->buf, sb->len, to, from, &len);
+	if (!out)
+		return -1;
+
+	strbuf_attach(sb, out, len, len);
+	return 0;
+}
+
 struct strbuf **strbuf_split_buf(const char *str, size_t slen,
 				 int terminator, int max)
 {
diff --git a/strbuf.h b/strbuf.h
index 39c14cf..4e9a2f8 100644
--- a/strbuf.h
+++ b/strbuf.h
@@ -45,6 +45,7 @@ static inline void strbuf_setlen(struct strbuf *sb, size_t len)
 extern void strbuf_trim(struct strbuf *);
 extern void strbuf_rtrim(struct strbuf *);
 extern void strbuf_ltrim(struct strbuf *);
+extern int strbuf_reencode(struct strbuf *sb, const char *from, const char *to);
 extern int strbuf_cmp(const struct strbuf *, const struct strbuf *);
 
 /*
-- 
2.0.0.rc1.436.g03cb729
Previous: Jeff KingNext: Jeff King
Message 39 of 42 in “handle alternate charsets for remote http errors”
  1. 0/9 handle alternate charsets for remote http errorsJeff King, May 21, 2014
  2. 1/9 test-lib: preserve GIT_CURL_VERBOSE from the environmentJeff King, May 21, 2014
  3. 2/9 strbuf: add strbuf_tolower functionJeff King, May 21, 2014
  4. Kyle J. McKayMay 22, 2014
  5. Jeff KingMay 22, 2014
  6. Junio C HamanoMay 22, 2014
  7. Jeff KingMay 22, 2014
  8. Junio C HamanoMay 22, 2014
  9. Jeff KingMay 23, 2014
  10. Kyle J. McKayMay 22, 2014
  11. Jeff KingMay 23, 2014
  12. Kyle J. McKayMay 23, 2014
  13. 3/9 daemon/config: factor out duplicate xstrdup_tolowerJeff King, May 21, 2014
  14. 4/9 http: normalize case of returned content-typeJeff King, May 21, 2014
  15. 5/9 t/lib-httpd: use write_script to copy CGI scriptsJeff King, May 21, 2014
  16. 6/9 t5550: test display of remote http error messagesJeff King, May 21, 2014
  17. 7/9 remote-curl: recognize text/plain with a charset parameterJeff King, May 21, 2014
  18. Kyle J. McKayMay 22, 2014
  19. Jeff KingMay 22, 2014
  20. Kyle J. McKayMay 22, 2014
  21. Jeff KingMay 22, 2014
  22. Peter KreftingMay 22, 2014
  23. Jeff KingMay 22, 2014
  24. Peter KreftingMay 22, 2014
  25. 8/9 strbuf: add strbuf_reencode helperJeff King, May 21, 2014
  26. 9/9 remote-curl: reencode http error messagesJeff King, May 21, 2014
  27. Kyle J. McKayMay 22, 2014
  28. Jeff KingMay 22, 2014
  29. Peter KreftingMay 22, 2014
  30. 0/9 handle alternate charsets for remote http errorsJeff King, May 22, 2014
  31. 1/8 test-lib: preserve GIT_CURL_VERBOSE from the environmentJeff King, May 22, 2014
  32. 2/8 t/lib-httpd: use write_script to copy CGI scriptsJeff King, May 22, 2014
  33. 3/8 t5550: test display of remote http error messagesJeff King, May 22, 2014
  34. 4/8 http: extract type/subtype portion of content-typeJeff King, May 22, 2014
  35. Kyle J. McKayMay 22, 2014
  36. Jeff KingMay 23, 2014
  37. Kyle J. McKayMay 23, 2014
  38. 5/8 http: optionally extract charset parameter from content-typeJeff King, May 22, 2014
  39. 6/8 strbuf: add strbuf_reencode helperJeff King, May 22, 2014
  40. 7/8 remote-curl: reencode http error messagesJeff King, May 22, 2014
  41. 8/8 http: default text charset to iso-8859-1Jeff King, May 22, 2014
  42. brian m. carlsonMay 23, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.