Re: [PATCH v6] format-patch --signature-file <file>
On Wed, May 21, 2014 at 02:58:42PM -0700, Junio C Hamano wrote:
> Jeremiah Mahler <jmmahler@gmail.com> writes:
>
Show 30 quoted lines
> The problem is a "cat" you added outside test_expect_*; the recent
> push is to have as little executable outside them, especially the
> "set-up" code to prepare for the real tests.
>
> i.e. we have been trying to write new tests (and convert old ones)
> like this:
>
> test_expect_success 'I test such and such ' '
> cat >input-for-test <<-\EOF &&
> here comes input
> EOF
> git command-to-be-tested <input-for-test >actual &&
> cat >expected <<-\EOF &&
> here comes expected output
> EOF
> test_cmp expected actual
> '
>
> not like this:
>
> cat >input-for-test <<-\EOF &&
> here comes input
> EOF
> test_expect_success 'I test such and such ' '
> git command-to-be-tested <input-for-test >actual &&
> cat >expected <<-\EOF &&
> here comes expected output
> EOF
> test_cmp expected actual
> '
Now I understand.
Below is one of the updated test cases.
test_expect_success 'format-patch --signature-file=mail-signature' '
cat >mail-signature <<-\EOF
Test User <test.email@kernel.org>
http://git.kernel.org/cgit/git/git.git
git.kernel.org/?p=git/git.git;a=summary
EOF
git format-patch --stdout --signature-file=mail-signature -1 >output &&
check_patch output &&
sed -n -e "/^-- $/,\$p" <output | sed -e "1d" | sed -e "\$d" >output2 &&
test_cmp mail-signature output2
'
--
Jeremiah Mahler
jmmahler@gmail.com
http://github.com/jmahler
Jeremiah Mahler <jmmahler@gmail.com>