git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH v4 2/3] add trace_performance facility to debug performance issues

From
Jeff King <peff@peff.net>
Date
May 21, 2014, 20:55 UTC
Message-ID
<20140521205524.GB8381@sigill.intra.peff.net>
In-Reply-To
<537CF1C7.6030408@gmail.com>
On Wed, May 21, 2014 at 08:34:47PM +0200, Karsten Blees wrote:
Show 11 quoted lines
> Macros are mainly used to supply __FILE__ and __LINE__, so that lazy
> people don't need to think of a unique message for each use of
> trace_performance_*. Without __FILE__, __LINE__ and message, the
> output would be pretty useless (i.e. just the time without any
> additional info).
> 
> If there's platforms that don't support variadic macros, I'd suggest
> to drop the __FILE__ __LINE__ feature completely and make message
> mandatory (with the added benefit that manually provided messages
> don't change if the code is moved, i.e. trace logs would become
> somewhat comparable across versions).

I do think __FILE__ and __LINE__ can be useful, and it would not be the end of the world to simply omit them on platforms that can't do the variadic macros (there shouldn't be many these days, and I think they are used to living with reduced functionality in some cases).

But if this were attached to trace_printf, we would always have a message anyway, no?

-Peff
-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Previous: Karsten BleesNext: Karsten Blees
Message 10 of 17 in “add high resolution timer function to debug performance issues”
  1. 1/3 add high resolution timer function to debug performance issuesKarsten Blees, May 20, 2014
  2. Noel GrandinMay 21, 2014
  3. Karsten BleesMay 21, 2014
  4. Richard HansenMay 21, 2014
  5. Richard HansenMay 21, 2014
  6. Karsten BleesMay 22, 2014
  7. 2/3 add trace_performance facility to debug performance issuesKarsten Blees, May 20, 2014
  8. Jeff KingMay 21, 2014
  9. Karsten BleesMay 21, 2014
  10. Jeff KingMay 21, 2014
  11. 3/3 add command performance tracing to debug scripted commandsKarsten Blees, May 20, 2014
  12. Jeff KingMay 21, 2014
  13. Junio C HamanoMay 21, 2014
  14. Karsten BleesMay 22, 2014
  15. Jeff KingMay 22, 2014
  16. Karsten BleesMay 23, 2014
  17. Jeff KingMay 23, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.