From: Jeff King Date: Wed, 21 May 2014 20:55:24 GMT Subject: Re: [RFC/PATCH v4 2/3] add trace_performance facility to debug performance issues Message-ID: <20140521205524.GB8381@sigill.intra.peff.net> In-Reply-To: <537CF1C7.6030408@gmail.com> On Wed, May 21, 2014 at 08:34:47PM +0200, Karsten Blees wrote: > Macros are mainly used to supply __FILE__ and __LINE__, so that lazy > people don't need to think of a unique message for each use of > trace_performance_*. Without __FILE__, __LINE__ and message, the > output would be pretty useless (i.e. just the time without any > additional info). > > If there's platforms that don't support variadic macros, I'd suggest > to drop the __FILE__ __LINE__ feature completely and make message > mandatory (with the added benefit that manually provided messages > don't change if the code is moved, i.e. trace logs would become > somewhat comparable across versions). I do think __FILE__ and __LINE__ can be useful, and it would not be the end of the world to simply omit them on platforms that can't do the variadic macros (there shouldn't be many these days, and I think they are used to living with reduced functionality in some cases). But if this were attached to trace_printf, we would always have a message anyway, no? -Peff -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.