Re: [GUILT v2 28/29] Added guilt.reusebranch configuration option.
On Thu, May 15, 2014 at 09:37:05AM +0200, Per Cederqvist wrote:
> On Wed, May 14, 2014 at 5:53 PM, Jeff Sipek <jeffpc@josefsipek.net> wrote:
> > On Tue, May 13, 2014 at 10:31:04PM +0200, Per Cederqvist wrote:
Show 29 quoted lines
> >> +
> >> +for i in `seq 5`; do
> >> + if [ $i -ge 5 ]; then
> >> + shouldfail guilt pop
> >> + else
> >> + cmd guilt pop
> >> + fi
> >> + cmd git for-each-ref
> >> + cmd guilt push
> >> + cmd git for-each-ref
> >> + cmd guilt pop
> >> + cmd git for-each-ref
> >> +done
> >> +
> >> +# Check that "pop -a" does the right thing.
> >
> > What exactly is the right thing? no-op since the above loop poped
> > everything? (I'd make the comment say what the "right thing" is.)
>
> I'll rephrase that block of code like this:
>
> # Check that "pop -a" properly pops all patches.
> cmd guilt push -a
> cmd git for-each-ref
> cmd guilt pop -a
> cmd git for-each-ref
>
> Is that more clear? The test pushes all patches, checks that they
> are applied, removes them, checks that it worked.
--
NT is to UNIX what a doughnut is to a particle accelerator.