git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GUILT v2 00/29] Teach guilt import-commit how to create legal patch names, and more

From
JSJeff Sipek <jeffpc@josefsipek.net>
Date
May 13, 2014, 20:54 UTC
Message-ID
<20140513205443.GB4791@meili.valhalla.31bits.net>
In-Reply-To
<20140513204546.GB11391@thunk.org>
On Tue, May 13, 2014 at 04:45:47PM -0400, Theodore Ts'o wrote:
> On Tue, May 13, 2014 at 10:30:36PM +0200, Per Cederqvist wrote:
...
Show 9 quoted lines
> >  - Changed behavior: by default, guilt no longer changes branch when
> >    you push a patch.  You need to do "git config guilt.reusebranch
> >    false" to re-enable that.  This patch sets the default value of
> >    guilt.reusebranch to true; it should in my opinion change to false
> >    a year or two after the next release.
> 
> We've been living with the "origin" -> "guilt/origin" branch change
> for a year already, and in fact, these days I've gotten used to the
> new behavior.  Is it really worth it to change the default?

So, at first I was skeptical about the branch name prefix change. I've used it for about a year now, and I love it. When I first read Per's idea to change the default to the old-style, I was a bit sad but I understand the motivation.

I'm open to either mode being the default since it's easy enough for me to change it for me (thanks, ~/.gitconfig) but I think more people should benefit from the added safety against accidental git-push. (I also like being able to use guilt/master..master to get only the commits I care about.) Thoughts?

Jeff.
-- 
Intellectuals solve problems; geniuses prevent them
		- Albert Einstein
Previous: Theodore Ts'oNext: Per Cederqvist
Message 61 of 63 in “[GUILT v2 00/29] Teach guilt import-commit how to create legal patch names, and more”
  1. Per CederqvistMay 13, 2014
  2. 01/29 The tests should not fail if guilt.diffstat is set.Per Cederqvist, May 13, 2014
  3. 02/29 Allow "guilt delete -f" to run from a dir which contains spaces.Per Cederqvist, May 13, 2014
  4. 03/29 Added test case for "guilt delete -f".Per Cederqvist, May 13, 2014
  5. 04/29 Allow "guilt import-commit" to run from a dir which contains spaces.Per Cederqvist, May 13, 2014
  6. Jeff SipekMay 13, 2014
  7. 05/29 "guilt new": Accept more than 4 arguments.Per Cederqvist, May 13, 2014
  8. 06/29 Fix the do_get_patch function.Per Cederqvist, May 13, 2014
  9. Jeff SipekMay 13, 2014
  10. Per CederqvistMay 14, 2014
  11. 07/29 Added test cases for "guilt fold".Per Cederqvist, May 13, 2014
  12. Jeff SipekMay 13, 2014
  13. Per CederqvistMay 14, 2014
  14. 08/29 Added more test cases for "guilt new": empty patches.Per Cederqvist, May 13, 2014
  15. Jeff SipekMay 14, 2014
  16. Per CederqvistMay 14, 2014
  17. 09/29 Test suite: properly check the exit status of commands.Per Cederqvist, May 13, 2014
  18. 10/29 Run test_failed if the exit status of a test script is bad.Per Cederqvist, May 13, 2014
  19. Jeff SipekMay 13, 2014
  20. 11/29 test suite: remove pointless redirection.Per Cederqvist, May 13, 2014
  21. 12/29 "guilt header": more robust header selection.Per Cederqvist, May 13, 2014
  22. Jeff SipekMay 15, 2014
  23. Per CederqvistMay 16, 2014
  24. Jeff SipekMay 16, 2014
  25. 13/29 Check that "guilt header '.*'" fails.Per Cederqvist, May 13, 2014
  26. Jeff SipekMay 15, 2014
  27. 14/29 Use "git check-ref-format" to validate patch names.Per Cederqvist, May 13, 2014
  28. Jeff SipekMay 15, 2014
  29. 15/29 Produce legal patch names in guilt-import-commit.Per Cederqvist, May 13, 2014
  30. Jeff SipekMay 15, 2014
  31. 16/29 Fix backslash handling when creating names of imported patches.Per Cederqvist, May 13, 2014
  32. Jeff SipekMay 13, 2014
  33. Per CederqvistMay 14, 2014
  34. Jeff SipekMay 14, 2014
  35. 17/29 "guilt graph" no longer loops when no patches are applied.Per Cederqvist, May 13, 2014
  36. Jeff SipekMay 13, 2014
  37. 18/29 guilt-graph: Handle commas in branch names.Per Cederqvist, May 13, 2014
  38. 19/29 Check that "guilt graph" works when working on a branch with a comma.Per Cederqvist, May 13, 2014
  39. Jeff SipekMay 13, 2014
  40. 20/29 "guilt graph": Handle patch names containing quotes.Per Cederqvist, May 13, 2014
  41. Jeff SipekMay 13, 2014
  42. 21/29 The log.decorate setting should not influence import-commit.Per Cederqvist, May 13, 2014
  43. 22/29 The log.decorate setting should not influence patchbomb.Per Cederqvist, May 13, 2014
  44. 23/29 The log.decorate setting should not influence guilt rebase.Per Cederqvist, May 13, 2014
  45. 24/29 disp no longer processes backslashes.Per Cederqvist, May 13, 2014
  46. Jeff SipekMay 13, 2014
  47. 25/29 "guilt push" now fails when there are no more patches to push.Per Cederqvist, May 13, 2014
  48. Jeff SipekMay 13, 2014
  49. Per CederqvistMay 14, 2014
  50. Jeff SipekMay 14, 2014
  51. 26/29 "guilt pop" now fails when there are no more patches to pop.Per Cederqvist, May 13, 2014
  52. Jeff SipekMay 13, 2014
  53. 27/29 Minor testsuite fix.Per Cederqvist, May 13, 2014
  54. 28/29 Added guilt.reusebranch configuration option.Per Cederqvist, May 13, 2014
  55. Jeff SipekMay 14, 2014
  56. Per CederqvistMay 15, 2014
  57. Jeff SipekMay 15, 2014
  58. 29/29 Added a short style guide, and Emacs settings.Per Cederqvist, May 13, 2014
  59. Jeff SipekMay 13, 2014
  60. Theodore Ts'oMay 13, 2014
  61. Jeff SipekMay 13, 2014
  62. Per CederqvistMay 13, 2014
  63. Per CederqvistMay 14, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.