Re: [PATCH 1/2] inline constant return from error() function

From: Jonathan Nieder <jrnieder@gmail.com>
Date: May 12, 2014, 18:44 UTC
Message-ID: <20140512184426.GO9218@google.com>
In-Reply-To: <20140506151441.GA25768@sigill.intra.peff.net>

Hi,

Jeff King wrote:

> On Mon, May 05, 2014 at 05:29:38PM -0400, Jeff King wrote:

>> I cannot think of any other way to make the compiler aware of the
>> constant value, but perhaps somebody else is more clever than I am.
>
> This came to me in a dream, and seems to work.

Clever. :)  Thanks for thinking it up.

[...]

Show 12 quoted lines

> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -331,7 +331,11 @@ extern void warning(const char *err, ...) __attribute__((format (printf, 1, 2)))
>   * using the function as usual.
>   */
>  #if defined(__GNUC__) && ! defined(__clang__)
> -#define error(...) (error(__VA_ARGS__), -1)
> +static inline int const_error(void)
> +{
> +	return -1;
> +}
> +#define error(...) (error(__VA_ARGS__), const_error())

I wish we could just make error() an inline function that calls some print_error() helper, but I don't believe all compilers used to build git are smart enough to inline uses of varargs. So this looks like the right thing to do.

I kind of wish we weren't in so much of an arms race with static analyzers. Is there some standard way to submit our code as "an idiom that should continue not to produce warnings" to be included in a testsuite and prevent problems in the future?

Thanks, Jonathan