git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Detect endianness on more platforms that don't use BYTE_ORDER

From
Charles Bailey <cbailey32@bloomberg.net>
Date
May 2, 2014, 16:58 UTC
Message-ID
<20140502165830.GA29339@hashpling.org>
In-Reply-To
<xmqqwqe4azyd.fsf@gitster.dls.corp.google.com>
On Fri, May 02, 2014 at 09:48:58AM -0700, Junio C Hamano wrote:
Show 5 quoted lines
> Charles Bailey <cbailey32@bloomberg.net> writes:
> 
> > ---
> 
> Please sign-off your patches ;-)
Oops! Please consider this patch...
Signed-off-by: Charles Bailey <cbailey32@bloomberg.net>
> This swaps the precedence of BYTE_ORDER and __BYTE_ORDER from the
> original, which we may not want to.  It is easy for me to swap the
> order of if/elif to restore it, so it is not a big deal, though.

I think I swapped the precedence (semi-deliberately) because I found a proposal to standardize the BYTE_ORDER variant. I claim that any platform which provides both but with differing senses is somewhat broken so I cannot see the precedence mattering much. I don't mind either way.

Charles.
Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 11 in “Add extra logic required to detect endianness on Solaris”
  1. Add extra logic required to detect endianness on SolarisCharles Bailey, May 1, 2014
  2. Junio C HamanoMay 1, 2014
  3. Junio C HamanoMay 1, 2014
  4. Junio C HamanoMay 1, 2014
  5. Charles BaileyMay 2, 2014
  6. Detect endianness on more platforms that don't use BYTE_ORDERCharles Bailey, May 2, 2014
  7. Junio C HamanoMay 2, 2014
  8. Charles BaileyMay 2, 2014
  9. Junio C HamanoMay 2, 2014
  10. Junio C HamanoMay 2, 2014
  11. Charles BaileyMay 2, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.