git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/6] run_external_diff: use an argv_array for the command line

From
Jeff King <peff@peff.net>
Date
Apr 20, 2014, 01:35 UTC
Message-ID
<20140420013500.GB10531@sigill.intra.peff.net>
In-Reply-To
<CAA6TxYu=AX_RWQq4gr7cv6ZppPerRw30NY_Wbi1r8qEBma7Ctg@mail.gmail.com>
On Sun, Apr 20, 2014 at 02:09:49AM +0400, Max L wrote:
Show 5 quoted lines
> One more note: at this moment the problem is slightly deeper. This
> array is next passed to the execvp function, which now falls with
> EFAULT on two my machines (both faced this problem after upgrading to
> ubuntu 14.04, everything 'worked' fine before, looks like now execvp
> checks input more strictly). This leads to non-working 'git difftool'.

Interesting. We're overwriting whatever is after spawn_arg on the stack, so I'd expect the fork/exec to work, but the function to complain while popping the stack frame (though I couldn't get it to do so). I wonder if some kind of stack protection is kicking in, and the NULL doesn't get written or something. Either way, we should definitely address it.

-Peff
Previous: Max LNext: Eric Sunshine
Message 4 of 10 in “run_external_diff cleanups”
  1. 0/6 run_external_diff cleanupsJeff King, Apr 19, 2014
  2. 1/6 run_external_diff: use an argv_array for the command lineJeff King, Apr 19, 2014
  3. Max LApr 19, 2014
  4. Jeff KingApr 20, 2014
  5. Eric SunshineApr 20, 2014
  6. 2/6 run_external_diff: use an argv_array for the environmentJeff King, Apr 19, 2014
  7. 3/6 run_external_diff: clean up error handlingJeff King, Apr 19, 2014
  8. 4/6 run_external_diff: drop fflush(NULL)Jeff King, Apr 19, 2014
  9. 5/6 run_external_diff: hoist common bits out of conditionalJeff King, Apr 19, 2014
  10. 6/6 run_external_diff: refactor cmdline setup logicJeff King, Apr 19, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.