[PATCH 4/6] run_external_diff: drop fflush(NULL)
- From
Jeff King <peff@peff.net>
- Date
- Apr 19, 2014, 19:19 UTC
- Message-ID
- <20140419191930.GD8981@sigill.intra.peff.net>
- In-Reply-To
- <20140419191128.GA9266@sigill.intra.peff.net>
This fflush was added in d5535ec (Use run_command() to spawn external diff programs instead of fork/exec., 2007-10-19), because flushing buffers before forking is a good habit.
But later, 7d0b18a (Add output flushing before fork(), 2008-08-04) added it to the generic run-command interface, meaning that our flush here is redundant.
Signed-off-by: Jeff King <peff@peff.net> --- diff.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/diff.c b/diff.c index b517d01..fdb7f6c 100644 --- a/diff.c +++ b/diff.c @@ -2928,7 +2928,6 @@ static void run_external_diff(const char *pgm, argv_array_push(&argv, pgm); argv_array_push(&argv, name); } - fflush(NULL); argv_array_pushf(&env, "GIT_DIFF_PATH_COUNTER=%d", ++o->diff_path_counter); argv_array_pushf(&env, "GIT_DIFF_PATH_TOTAL=%d", q->nr);
-- 1.9.1.656.ge8a0637