Re: [PATCH] t4212: handle systems with post-apocalyptic gmtime

From: Jeff King <peff@peff.net>
Date: Mar 26, 2014, 20:38 UTC
Message-ID: <20140326203830.GA16332@sigill.intra.peff.net>
In-Reply-To: <20140326203618.GA6991@hashpling.org>

On Wed, Mar 26, 2014 at 08:36:18PM +0000, Charles Bailey wrote:

Show 18 quoted lines

> On Wed, Mar 26, 2014 at 03:40:43PM -0400, Jeff King wrote:
> > On Wed, Mar 26, 2014 at 03:33:59PM -0400, Jeff King wrote:
> > 
> > > That being said, is the AIX value actually right? I did not look closely
> > > at first, but just assumed that it was vaguely right. But:
> > > 
> > >   999999999999999999 / (86400 * 365)
> > > 
> > > is something like 31 billion years in the future, not 160 million.
> > > A real date calculation will have a few tweaks (leap years, etc), but
> > > that is orders of magnitude off.
> > 
> > Assuming my math is right, then here is the most sensible patch, IMHO.
> > 
> 
> Perhaps hold onto this one for a little while longer. Splitting things
> out from the test is giving me some inconsistent results, there may be
> something else going wrong in our environment here.

By the way, can you confirm that this is a 64-bit system? On a 32-bit system, we should be triggering different code paths (we fail at the strtoul level). Those should be checked by the previous tests, but I'd like to make sure.

-Peff