git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/5] log: do not segfault on gmtime errors

From
Charles Bailey <cbailey32@bloomberg.net>
Date
Mar 26, 2014, 11:05 UTC
Message-ID
<20140326110559.GA32625@hashpling.org>
In-Reply-To
<20140224074905.GE9969@sigill.intra.peff.net>
On Mon, Feb 24, 2014 at 02:49:05AM -0500, Jeff King wrote:
Show 7 quoted lines
> +# date is within 2^63-1, but enough to choke glibc's gmtime
> +test_expect_success 'absurdly far-in-future dates produce sentinel' '
> +	commit=$(munge_author_date HEAD 999999999999999999) &&
> +	echo "Thu Jan 1 00:00:00 1970 +0000" >expect &&
> +	git log -1 --format=%ad $commit >actual &&
> +	test_cmp expect actual
> +'

Git on AIX seems happy to convert this to Thu Oct 24 18:46:39 162396404 -0700. I don't know if this is correct for the given input but the test fails.

Charles.
Previous: Jeff KingNext: Jeff King
Message 16 of 48 in “handle bogus commit dates”
  1. 0/5 handle bogus commit datesJeff King, Feb 24, 2014
  2. 1/5 t4212: test bogus timestamps with git-logJeff King, Feb 24, 2014
  3. 2/5 fsck: report integer overflow in author timestampsJeff King, Feb 24, 2014
  4. 3/5 date: check date overflow against time_tJeff King, Feb 24, 2014
  5. 4/5 log: handle integer overflow in timestampsJeff King, Feb 24, 2014
  6. Junio C HamanoFeb 24, 2014
  7. Jeff KingFeb 24, 2014
  8. Junio C HamanoFeb 24, 2014
  9. Jeff KingFeb 24, 2014
  10. Junio C HamanoFeb 24, 2014
  11. 5/5 log: do not segfault on gmtime errorsJeff King, Feb 24, 2014
  12. René ScharfeMar 22, 2014
  13. Jeff KingMar 24, 2014
  14. René ScharfeMar 24, 2014
  15. Jeff KingMar 24, 2014
  16. Charles BaileyMar 26, 2014
  17. Jeff KingMar 26, 2014
  18. t4212: handle systems with post-apocalyptic gmtimeJeff King, Mar 26, 2014
  19. Junio C HamanoMar 26, 2014
  20. Jeff KingMar 26, 2014
  21. Jeff KingMar 26, 2014
  22. Jeff KingMar 26, 2014
  23. Charles BaileyMar 26, 2014
  24. Jeff KingMar 26, 2014
  25. Charles BaileyMar 26, 2014
  26. Charles BaileyMar 26, 2014
  27. Jeff KingMar 26, 2014
  28. Charles BaileyMar 26, 2014
  29. Jeff KingMar 27, 2014
  30. Junio C HamanoMar 28, 2014
  31. Jeff KingMar 28, 2014
  32. Junio C HamanoMar 28, 2014
  33. Jeff KingMar 28, 2014
  34. Junio C HamanoMar 28, 2014
  35. Jeff KingApr 1, 2014
  36. 1/2 date: recognize bogus FreeBSD gmtime outputJeff King, Apr 1, 2014
  37. René ScharfeApr 1, 2014
  38. Junio C HamanoApr 1, 2014
  39. René ScharfeApr 1, 2014
  40. Jeff KingApr 1, 2014
  41. 2/2 t4212: loosen far-in-future test for AIXJeff King, Apr 1, 2014
  42. work around unreliable gmtime errors on AIXJeff King, Apr 1, 2014
  43. Junio C HamanoApr 1, 2014
  44. Jeff KingApr 1, 2014
  45. Junio C HamanoMar 26, 2014
  46. Jeff KingMar 26, 2014
  47. Junio C HamanoMar 26, 2014
  48. Jeff KingMar 26, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.