Re: [PATCH 03/10] t4018: an infrastructure to test hunk headers

From: Jeff King <peff@peff.net>
Date: Mar 24, 2014, 21:36 UTC
Message-ID: <20140324213659.GF13728@sigill.intra.peff.net>
In-Reply-To: <52505977c20a480941ae1f85f50ffb7a0bbffedb.1395433874.git.j6t@kdbg.org>

On Fri, Mar 21, 2014 at 10:07:15PM +0100, Johannes Sixt wrote:

Show 6 quoted lines

> Add an infrastructure that simplifies adding new tests of the hunk
> header regular expressions.
> 
> To add new tests, a file with the syntax to test can be dropped in the
> directory t4018. The README file explains how a test file must contain;
> the README itself tests the default behavior.

I really like the cleanups you've done in t4018. I noticed how messy it was when I modified it recently, but I didn't take the time to clean it.

Show 11 quoted lines

> diff --git a/t/t4018/README b/t/t4018/README
> new file mode 100644
> index 0000000..283e01cc
> --- /dev/null
> +++ b/t/t4018/README
> @@ -0,0 +1,18 @@
> +How to write RIGHT test cases
> +=============================
> +
> +Insert the word "ChangeMe" (exactly this form) at a distance of
> +at least two lines from the line that must appear in the hunk header.

The existing tests use -U1 to make writing cases simpler. Is there a reason not to continue that (or if you found that porting the existing cases was not a chore with -U3, I can buy that argument, too)?

Show 5 quoted lines

> +The text that must appear in the hunk header must contain the word
> +"right", but in all upper-case, like in the title above.
> +
> +To mark a test case that highlights a malfunction, insert the word
> +BROKEN in all lower-case somewhere in the file.

I wondered why you wouldn't write them in the case you are indicating, when...

> +This text is a bit twisted and out of order, but it is itself a
> +test case for the default hunk header pattern. Know what you are doing
> +if you change it.

Ah. Clever. :)

-Peff