Re: No progress from push when using bitmaps

From: Jeff King <peff@peff.net>
Date: Mar 13, 2014, 21:26 UTC
Message-ID: <20140313212626.GA23618@sigill.intra.peff.net>
In-Reply-To: <CAJo=hJth1YB+u2Y9S0X3xk7s2-HcPP4_k03qprHBU4A9721i8g@mail.gmail.com>

On Wed, Mar 12, 2014 at 05:21:21PM -0700, Shawn Pearce wrote:

Show 11 quoted lines

> Today I tried pushing a copy of linux.git from a client that had
> bitmaps into a JGit server. The client stalled for a long time with no
> progress, because it reused the existing pack. No progress appeared
> while it was sending the existing file on the wire:
> 
>   $ git push git://localhost/linux.git master
>   Reusing existing pack: 2938117, done.
>   Total 2938117 (delta 0), reused 0 (delta 0)
>   remote: Resolving deltas:  66% (1637269/2455727)
> 
> This is not the best user experience. :-(

Yeah, I agree that sucks. I hadn't noticed it, as I don't typically have my client repos bitmapped (and on fetch, the interesting progress is coming from the local index-pack).

It would definitely be good to have throughput measurements while writing out the pack. However, I'm not sure we have anything useful to count. We know the total number of objects we're reusing, but we're not actually parsing the data; we're just blitting it out as a stream. I think the progress code will need some refactoring to handle a throughput-only case.

-Peff