Re: What's cooking in git.git (Mar 2014, #02; Tue, 11)

From: Jeff King <peff@peff.net>
Date: Mar 12, 2014, 20:03 UTC
Message-ID: <20140312200348.GB1816@sigill.intra.peff.net>
In-Reply-To: <20140312193509.GA1816@sigill.intra.peff.net>

On Wed, Mar 12, 2014 at 03:35:09PM -0400, Jeff King wrote:

Show 11 quoted lines

> On Tue, Mar 11, 2014 at 03:12:11PM -0700, Junio C Hamano wrote:
> 
> > * jk/warn-on-object-refname-ambiguity (2014-01-09) 6 commits
> [...]
> Having looked at it again, I really think it is not worth pursuing. The
> end goal is not that interesting, there is a lot of code introduced, and
> a reasonable chance of accidentally introducing regressions and/or
> making the code less maintainable.  Keeping the existing code (which
> just disables the check for cat-file) is probably the sanest course of
> action. We can do a similar thing for "rev-list --stdin" if we want, or
> we can wait until somebody complains.

Having said that, here are two follow-on patches. The first is an extra cat-file cleanup, and the second adjusts "rev-list --stdin". I am on the fence on both of them, so I will leave it up to your judgement.

  [1/2]: cat-file: restore warn_on_object_refname_ambiguity flag
  [2/2]: rev-list: disable object/refname ambiguity check with --stdin

-Peff