git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diffcore.h: be explicit about the signedness of is_binary

From
Jeff King <peff@peff.net>
Date
Feb 24, 2014, 02:09 UTC
Message-ID
<20140224020940.GB7959@sigill.intra.peff.net>
In-Reply-To
<m2ob1xba94.fsf@richlowe.net>
On Sun, Feb 23, 2014 at 07:54:47PM -0500, Richard Lowe wrote:
Show 6 quoted lines
> Bitfields need to specify their signedness explicitly or the compiler is
> free to default as it sees fit.  With compilers that default 'unsigned'
> (SUNWspro 12 seems to do this) the tri-state nature of is_binary
> vanishes and all files are treated as binary.
> 
> Signed-off-by: Richard Lowe <richlowe@richlowe.net>

Thanks, I wasn't aware of this corner of the standard when I wrote it. Your fix is obviously correct.

-Peff
Previous: Richard LoweNext: Junio C Hamano
Message 2 of 3 in “diffcore.h: be explicit about the signedness of is_binary”
  1. diffcore.h: be explicit about the signedness of is_binaryRichard Lowe, Feb 24, 2014
  2. Jeff KingFeb 24, 2014
  3. Junio C HamanoFeb 24, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.