From: Jeff King <peff@peff.net>
Date: Mon, 24 Feb 2014 02:09:40 GMT
Subject: Re: [PATCH] diffcore.h: be explicit about the signedness of is_binary
Message-ID: <20140224020940.GB7959@sigill.intra.peff.net>
In-Reply-To: <m2ob1xba94.fsf@richlowe.net>

On Sun, Feb 23, 2014 at 07:54:47PM -0500, Richard Lowe wrote:

> Bitfields need to specify their signedness explicitly or the compiler is
> free to default as it sees fit.  With compilers that default 'unsigned'
> (SUNWspro 12 seems to do this) the tri-state nature of is_binary
> vanishes and all files are treated as binary.
> 
> Signed-off-by: Richard Lowe <richlowe@richlowe.net>

Thanks, I wasn't aware of this corner of the standard when I wrote it.
Your fix is obviously correct.

-Peff