Re: [PATCH 3/3] make commit --verbose work with --no-status

From: Jeff King <peff@peff.net>
Date: Feb 22, 2014, 08:31 UTC
Message-ID: <20140222083110.GE1576@sigill.intra.peff.net>
In-Reply-To: <1393009762-31133-4-git-send-email-rctay89@gmail.com>

On Sat, Feb 22, 2014 at 03:09:22AM +0800, Tay Ray Chuan wrote:

Show 12 quoted lines

> @@ -1141,7 +1146,12 @@ static int parse_and_validate_options(int argc, const char *argv[],
>  	if (all && argc > 0)
>  		die(_("Paths with -a does not make sense."));
>  
> -	if (status_format != STATUS_FORMAT_DEFAULT)
> +	if (verbose && !include_status) {
> +		include_status = 1;
> +		status_format = STATUS_FORMAT_NONE;
> +	}
> +
> +	if (status_format != STATUS_FORMAT_DEFAULT && !verbose)
>  		dry_run = 1;

What happens here when there is an alternate status format _and_ --verbose is used? If I say "git commit --porcelain" it should imply --dry-run. But "git commit --porcelain --verbose" no longer does so after your patch.

-Peff