Re: [PATCH v4 08/17] trailer: add interpret-trailers command

From: Christian Couder <chriscool@tuxfamily.org>
Date: Feb 6, 2014, 20:12 UTC
Message-ID: <20140206.211228.1189883848366712745.chriscool@tuxfamily.org>
In-Reply-To: <CAPig+cRMBDr1D+3ad6y95ucxynO1qbRnsbUAfjtLkoR3+mjxZg@mail.gmail.com>

From: Eric Sunshine <sunshine@sunshineco.com>

Show 20 quoted lines

>
> On Thu, Jan 30, 2014 at 1:49 AM, Christian Couder
> <chriscool@tuxfamily.org> wrote:
>> diff --git a/trailer.h b/trailer.h
>> new file mode 100644
>> index 0000000..9db4459
>> --- /dev/null
>> +++ b/trailer.h
>> @@ -0,0 +1,6 @@
>> +#ifndef TRAILER_H
>> +#define TRAILER_H
>> +
>> +void process_trailers(const char *infile, int trim_empty, int argc, const char **argv);
>> +
>> +#endif /* TRAILER_H */
> 
> One might reasonably expect trailer.h and the process_trailers()
> declaration to be introduced by patch 7/17 ("trailer: put all the
> processing together and print") in which process_trailers() is defined
> in trailer.c.

On the other hand, I think that it is not so nice to add a header file like trailer.h unless it is included at least once.

Maybe I can squash this patch with the previous one, but then the series might be a little bit more difficult to understand.

Thanks, Christian.