git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 01/17] Add data structures and basic functions for commit trailers

From
Christian Couder <chriscool@tuxfamily.org>
Date
Jan 30, 2014, 06:49 UTC
Message-ID
<20140130064921.7504.87498.chriscool@tuxfamily.org>
In-Reply-To
<20140130064217.7504.473.chriscool@tuxfamily.org>

We will use a doubly linked list to store all information about trailers and their configuration.

This way we can easily remove or add trailers to or from trailer lists while traversing the lists in either direction.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 Makefile  |  1 +
 trailer.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 49 insertions(+)
 create mode 100644 trailer.c
diff --git a/Makefile b/Makefile
index b4af1e2..ec90feb 100644
--- a/Makefile
+++ b/Makefile
@@ -871,6 +871,7 @@ LIB_OBJS += submodule.o
 LIB_OBJS += symlinks.o
 LIB_OBJS += tag.o
 LIB_OBJS += trace.o
+LIB_OBJS += trailer.o
 LIB_OBJS += transport.o
 LIB_OBJS += transport-helper.o
 LIB_OBJS += tree-diff.o
diff --git a/trailer.c b/trailer.c
new file mode 100644
index 0000000..aed25e1
--- /dev/null
+++ b/trailer.c
@@ -0,0 +1,48 @@
+#include "cache.h"
+/*
+ * Copyright (c) 2013 Christian Couder <chriscool@tuxfamily.org>
+ */
+
+enum action_where { WHERE_AFTER, WHERE_BEFORE };
+enum action_if_exist { EXIST_ADD_IF_DIFFERENT, EXIST_ADD_IF_DIFFERENT_NEIGHBOR,
+		       EXIST_ADD, EXIST_OVERWRITE, EXIST_DO_NOTHING };
+enum action_if_missing { MISSING_ADD, MISSING_DO_NOTHING };
+
+struct conf_info {
+	char *name;
+	char *key;
+	char *command;
+	enum action_where where;
+	enum action_if_exist if_exist;
+	enum action_if_missing if_missing;
+};
+
+struct trailer_item {
+	struct trailer_item *previous;
+	struct trailer_item *next;
+	const char *token;
+	const char *value;
+	struct conf_info *conf;
+};
+
+static int same_token(struct trailer_item *a, struct trailer_item *b, int alnum_len)
+{
+	return !strncasecmp(a->token, b->token, alnum_len);
+}
+
+static int same_value(struct trailer_item *a, struct trailer_item *b)
+{
+	return !strcasecmp(a->value, b->value);
+}
+
+static int same_trailer(struct trailer_item *a, struct trailer_item *b, int alnum_len)
+{
+	return same_token(a, b, alnum_len) && same_value(a, b);
+}
+
+/* Get the length of buf from its beginning until its last alphanumeric character */
+static size_t alnum_len(const char *buf, size_t len)
+{
+	while (--len >= 0 && !isalnum(buf[len]));
+	return len + 1;
+}
-- 
1.8.5.2.201.gacc5987
Previous: Christian CouderNext: Eric Sunshine
Message 2 of 33 in “Add interpret-trailers builtin”
  1. 00/17 Add interpret-trailers builtinChristian Couder, Jan 30, 2014
  2. 01/17 Add data structures and basic functions for commit trailersChristian Couder, Jan 30, 2014
  3. Eric SunshineJan 30, 2014
  4. 02/17 trailer: process trailers from file and argumentsChristian Couder, Jan 30, 2014
  5. Eric SunshineJan 31, 2014
  6. 03/17 trailer: read and process config informationChristian Couder, Jan 30, 2014
  7. Eric SunshineJan 31, 2014
  8. 04/17 trailer: process command line trailer argumentsChristian Couder, Jan 30, 2014
  9. Eric SunshineJan 31, 2014
  10. 05/17 strbuf: add strbuf_isspace()Christian Couder, Jan 30, 2014
  11. Eric SunshineJan 31, 2014
  12. Eric SunshineJan 31, 2014
  13. 06/17 trailer: parse trailers from input fileChristian Couder, Jan 30, 2014
  14. Eric SunshineJan 31, 2014
  15. 07/17 trailer: put all the processing together and printChristian Couder, Jan 30, 2014
  16. 08/17 trailer: add interpret-trailers commandChristian Couder, Jan 30, 2014
  17. Eric SunshineJan 31, 2014
  18. Christian CouderFeb 6, 2014
  19. 09/17 trailer: add tests for "git interpret-trailers"Christian Couder, Jan 30, 2014
  20. 10/17 trailer: if no input file is passed, read from stdinChristian Couder, Jan 30, 2014
  21. Eric SunshineFeb 2, 2014
  22. Christian CouderFeb 6, 2014
  23. Junio C HamanoFeb 6, 2014
  24. Christian CouderFeb 9, 2014
  25. 11/17 trailer: add new_trailer_item() functionChristian Couder, Jan 30, 2014
  26. Eric SunshineFeb 2, 2014
  27. 12/17 strbuf: add strbuf_replace()Christian Couder, Jan 30, 2014
  28. Eric SunshineJan 31, 2014
  29. 13/17 trailer: execute command from 'trailer.<name>.command'Christian Couder, Jan 30, 2014
  30. 14/17 trailer: add tests for trailer commandChristian Couder, Jan 30, 2014
  31. 15/17 trailer: set author and committer env variablesChristian Couder, Jan 30, 2014
  32. 16/17 trailer: add tests for commands using env variablesChristian Couder, Jan 30, 2014
  33. 17/17 Documentation: add documentation for 'git interpret-trailers'Christian Couder, Jan 30, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.