Re: [PATCH] Added get sendmail from .mailrc

From: Eric Wong <normalperson@yhbt.net>
Date: Jan 26, 2014, 09:17 UTC
Message-ID: <20140126091709.GA31073@dcvr.yhbt.net>
In-Reply-To: <20140126073438.GA3858@kirill.netbynet.ru>

Brilliantov Kirill Vladimirovich <brilliantov@inbox.ru> wrote:

Show 17 quoted lines

> On 2014-01-25 22:37:21, Eric Wong wrote:
> > Brilliantov Kirill Vladimirovich <brilliantov@inbox.ru> wrote:
> > > --- a/git-send-email.perl
> > > +++ b/git-send-email.perl
> > > @@ -28,6 +28,7 @@ use File::Temp qw/ tempdir tempfile /;
> > >  use File::Spec::Functions qw(catfile);
> > >  use Error qw(:try);
> > >  use Git;
> > > +use File::HomeDir;
> > 
> > We should probably avoid a new dependency and also remain consistent
> > with the rest of git handles home directories.
> > 
> > Unfortunately, expand_user_path()/git_config_pathname() isn't currently
> > exposed to scripters right now...
> 
> Ok, if new dependency is not allowed I see next ways:

Not saying it's not allowed. I meant we should probably expose expand_user_path()/git_config_pathname() C functions to script helpers (so git-config or git-rev-parse can provide them to sh or perl scripts).