Re: [PATCH] Added get sendmail from .mailrc

From: Eric Wong <normalperson@yhbt.net>
Date: Jan 25, 2014, 22:37 UTC
Message-ID: <20140125223721.GA2684@dcvr.yhbt.net>
In-Reply-To: <1390643210-5748-1-git-send-email-brilliantov@inbox.ru>

Brilliantov Kirill Vladimirovich <brilliantov@inbox.ru> wrote:

> Signed-off-by: Brilliantov Kirill Vladimirovich <brilliantov@inbox.ru>
> ---
>  git-send-email.perl | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)

Some documentation references to .mailrc and its format would be nice.

Show 7 quoted lines

> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -28,6 +28,7 @@ use File::Temp qw/ tempdir tempfile /;
>  use File::Spec::Functions qw(catfile);
>  use Error qw(:try);
>  use Git;
> +use File::HomeDir;

We should probably avoid a new dependency and also remain consistent with the rest of git handles home directories.

Unfortunately, expand_user_path()/git_config_pathname() isn't currently exposed to scripters right now...