Re: [PATCH v2 04/16] trailer: process command line trailer arguments

From: Christian Couder <chriscool@tuxfamily.org>
Date: Jan 26, 2014, 17:28 UTC
Message-ID: <20140126.182841.788650091041834492.chriscool@tuxfamily.org>
In-Reply-To: <xmqq4n4xt0dv.fsf@gitster.dls.corp.google.com>

Show 24 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
>>> +static struct trailer_item *create_trailer_item(const char *string)
>>> +{
>>> +	struct strbuf tok = STRBUF_INIT;
>>> +	struct strbuf val = STRBUF_INIT;
>>> +	struct trailer_item *new;
>>> +
>>> +	parse_trailer(&tok, &val, string);
>>> +
>>> +	int tok_alnum_len = alnum_len(tok.buf, tok.len);
>>
>> decl-after-stmt.
>>
>>> +
>>> +	/* Lookup if the token matches something in the config */
>>> +	struct trailer_item *item;
> 
> ditto.
> 
>>> +	for (item = first_conf_item; item; item = item->next)
>>> +	{
> 
> Style.

The decl-after-stmt and style problems are fixed in the new v3 series I just sent.

> I wonder if Cc list is being a bit too wide for this series, by the
> way.

I included only people who where part of the discussions at some point. I guess that if they are not interested anymore they can ask to be removed from Cc.

Thanks, Christian.