git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 15/16] trailer: set author and committer env variables

From
Christian Couder <chriscool@tuxfamily.org>
Date
Jan 19, 2014, 08:53 UTC
Message-ID
<20140119085355.2734.55181.chriscool@tuxfamily.org>
In-Reply-To
<20140119083636.2734.14378.chriscool@tuxfamily.org>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 trailer.c | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/trailer.c b/trailer.c
index 549d381..3b21f57 100644
--- a/trailer.c
+++ b/trailer.c
@@ -1,5 +1,6 @@
 #include "cache.h"
 #include "run-command.h"
+#include "argv-array.h"
 /*
  * Copyright (c) 2013 Christian Couder <chriscool@tuxfamily.org>
  */
@@ -415,14 +416,40 @@ static int read_from_command(struct child_process *cp, struct strbuf *buf)
 	return 0;
 }
 
+static void setup_ac_env(struct argv_array *env, const char *ac_name, const char *ac_mail, const char *(*read)(int))
+{
+	if (!getenv(ac_name) || !getenv(ac_mail)) {
+		struct ident_split ident;
+		const char *namebuf, *mailbuf;
+		int namelen, maillen;
+		const char *ac_info = read(IDENT_NO_DATE);
+
+		if (split_ident_line(&ident, ac_info, strlen(ac_info)))
+			return;
+
+		namelen = ident.name_end - ident.name_begin;
+		namebuf = ident.name_begin;
+
+		maillen = ident.mail_end - ident.mail_begin;
+		mailbuf = ident.mail_begin;
+
+		argv_array_pushf(env, "%s=%.*s", ac_name, namelen, namebuf);
+		argv_array_pushf(env, "%s=%.*s", ac_mail, maillen, mailbuf);
+	}
+}
+
 static const char *apply_command(const char *command, const char *arg)
 {
+	struct argv_array env = ARGV_ARRAY_INIT;
 	struct strbuf cmd = STRBUF_INIT;
 	struct strbuf buf = STRBUF_INIT;
 	struct child_process cp;
 	const char *argv[] = {NULL, NULL};
 	const char *result = "";
 
+	setup_ac_env(&env, "GIT_AUTHOR_NAME", "GIT_AUTHOR_EMAIL", git_author_info);
+	setup_ac_env(&env, "GIT_COMMITTER_NAME", "GIT_COMMITTER_EMAIL", git_committer_info);
+
 	strbuf_addstr(&cmd, command);
 	if (arg)
 		strbuf_replace(&cmd, TRAILER_ARG_STRING, arg);
@@ -430,7 +457,7 @@ static const char *apply_command(const char *command, const char *arg)
 	argv[0] = cmd.buf;
 	memset(&cp, 0, sizeof(cp));
 	cp.argv = argv;
-	cp.env = local_repo_env;
+	cp.env = env.argv;
 	cp.no_stdin = 1;
 	cp.out = -1;
 	cp.use_shell = 1;
@@ -441,6 +468,7 @@ static const char *apply_command(const char *command, const char *arg)
 		result = strbuf_detach(&buf, NULL);
 
 	strbuf_release(&cmd);
+	argv_array_clear(&env);
 	return result;
 }
 
-- 
1.8.5.2.201.gacc5987
Previous: Christian CouderNext: Christian Couder
Message 19 of 20 in “Add interpret-trailers builtin”
  1. 00/16 Add interpret-trailers builtinChristian Couder, Jan 19, 2014
  2. 01/16 Add data structures and basic functions for commit trailersChristian Couder, Jan 19, 2014
  3. 02/16 trailer: process trailers from file and argumentsChristian Couder, Jan 19, 2014
  4. 03/16 trailer: read and process config informationChristian Couder, Jan 19, 2014
  5. 04/16 trailer: process command line trailer argumentsChristian Couder, Jan 19, 2014
  6. Junio C HamanoJan 21, 2014
  7. Junio C HamanoJan 21, 2014
  8. Christian CouderJan 26, 2014
  9. 05/16 strbuf: add strbuf_isspace()Christian Couder, Jan 19, 2014
  10. 06/16 trailer: parse trailers from input fileChristian Couder, Jan 19, 2014
  11. 07/16 trailer: put all the processing together and printChristian Couder, Jan 19, 2014
  12. 08/16 trailer: add interpret-trailers commandChristian Couder, Jan 19, 2014
  13. 09/16 trailer: add tests for "git interpret-trailers"Christian Couder, Jan 19, 2014
  14. 10/16 trailer: if no input file is passed, read from stdinChristian Couder, Jan 19, 2014
  15. 11/16 trailer: add new_trailer_item() functionChristian Couder, Jan 19, 2014
  16. 12/16 strbuf: add strbuf_replace()Christian Couder, Jan 19, 2014
  17. 13/16 trailer: execute command from 'trailer.<name>.command'Christian Couder, Jan 19, 2014
  18. 14/16 trailer: add tests for trailer commandChristian Couder, Jan 19, 2014
  19. 15/16 trailer: set author and committer env variablesChristian Couder, Jan 19, 2014
  20. 16/16 trailer: add tests for commands using env variablesChristian Couder, Jan 19, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.