git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] teach replace objects to sha1_object_info_extended()

From
Christian Couder <chriscool@tuxfamily.org>
Date
Dec 3, 2013, 20:46 UTC
Message-ID
<20131203.214617.1435733880353938948.chriscool@tuxfamily.org>
In-Reply-To
<20131202145225.GA12457@sigill.intra.peff.net>
From: Jeff King <peff@peff.net>
Show 7 quoted lines
>
> On Sat, Nov 30, 2013 at 02:51:18PM +0100, Christian Couder wrote:
> 
>> Here is a patch series to improve the way sha1_object_info_extended()
>> behaves when it is passed a replaced object.
> 
> Overall looks OK to me.
Thanks for reviewing it.
[...]
Show 8 quoted lines
> I checked the resulting behavior against the list I made earlier; looks
> like all of the _extended callsites are doing the right thing.
> 
> I do think the checks you added in 277336a (replace: forbid replacing an
> object with one of a different type, 2013-09-06) need updating. I
> started on that, but I wonder if all of cmd_replace should simply turn
> off read_replace_refs. I'd think it would always want to be dealing with
> the true objects.

Yeah, I think you are right. I will have a look and probably turn off read_replace_ref in cmd_replace() as you suggest.

Thanks, Christian.

Previous: Christian Couder
Message 11 of 11 in “teach replace objects to sha1_object_info_extended()”
  1. 0/5 teach replace objects to sha1_object_info_extended()Christian Couder, Nov 30, 2013
  2. 1/5 replace_object: don't check read_replace_refs twiceChristian Couder, Nov 30, 2013
  3. 2/5 introduce lookup_replace_object_extended() to pass flagsChristian Couder, Nov 30, 2013
  4. 3/5 Add an "unsigned flags" parameter to sha1_object_info_extended()Christian Couder, Nov 30, 2013
  5. 4/5 t6050: show that git cat-file --batch fails with replace objectsChristian Couder, Nov 30, 2013
  6. 5/5 sha1_file: perform object replacement in sha1_object_info_extended()Christian Couder, Nov 30, 2013
  7. Jeff KingDec 2, 2013
  8. Jeff KingDec 2, 2013
  9. Junio C HamanoDec 2, 2013
  10. Christian CouderDec 3, 2013
  11. Christian CouderDec 3, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.