git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/5] replace_object: don't check read_replace_refs twice

From
Christian Couder <chriscool@tuxfamily.org>
Date
Nov 30, 2013, 13:51 UTC
Message-ID
<20131130135124.2697.81789.chriscool@tuxfamily.org>
In-Reply-To
<20131130133934.2697.75781.chriscool@tuxfamily.org>

Since e1111cef (inline lookup_replace_object() calls, May 15 2011) the read_replace_refs global variable is checked twice, once in lookup_replace_object() and once again in do_lookup_replace_object().

As do_lookup_replace_object() is called only from lookup_replace_object(), we can remove the check in do_lookup_replace_object().

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 replace_object.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/replace_object.c b/replace_object.c
index d0b1548..cdcaf8c 100644
--- a/replace_object.c
+++ b/replace_object.c
@@ -97,9 +97,6 @@ const unsigned char *do_lookup_replace_object(const unsigned char *sha1)
 	int pos, depth = MAXREPLACEDEPTH;
 	const unsigned char *cur = sha1;
 
-	if (!read_replace_refs)
-		return sha1;
-
 	prepare_replace_object();
 
 	/* Try to recursively replace the object */
-- 
1.8.4.1.561.g12affca
Previous: Christian CouderNext: Christian Couder
Message 2 of 11 in “teach replace objects to sha1_object_info_extended()”
  1. 0/5 teach replace objects to sha1_object_info_extended()Christian Couder, Nov 30, 2013
  2. 1/5 replace_object: don't check read_replace_refs twiceChristian Couder, Nov 30, 2013
  3. 2/5 introduce lookup_replace_object_extended() to pass flagsChristian Couder, Nov 30, 2013
  4. 3/5 Add an "unsigned flags" parameter to sha1_object_info_extended()Christian Couder, Nov 30, 2013
  5. 4/5 t6050: show that git cat-file --batch fails with replace objectsChristian Couder, Nov 30, 2013
  6. 5/5 sha1_file: perform object replacement in sha1_object_info_extended()Christian Couder, Nov 30, 2013
  7. Jeff KingDec 2, 2013
  8. Jeff KingDec 2, 2013
  9. Junio C HamanoDec 2, 2013
  10. Christian CouderDec 3, 2013
  11. Christian CouderDec 3, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.